pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Christoph Berg <myon@debian.org>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Banck <michael.banck@credativ.de>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Offline enabling/disabling of data checksums
Date: Fri, 22 Mar 2019 16:30:12 +0100
Message-ID: <20190322153012.GE32388@msg.df7cb.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1903221514390.2198@lancre>
References: <20190319164717.ex2pw66zusbdqg2o@alap3.anarazel.de>
	<20190319230907.GA3488@paquier.xyz>
	<20190320051750.GA26601@paquier.xyz>
	<alpine.DEB.2.21.1903201012040.24709@lancre>
	<20190320125451.GA20192@paquier.xyz>
	<alpine.DEB.2.21.1903201712370.24709@lancre>
	<20190320225924.GC20192@paquier.xyz>
	<alpine.DEB.2.21.1903210745310.3843@lancre>
	<20190322002727.GJ20192@paquier.xyz>
	<alpine.DEB.2.21.1903221514390.2198@lancre>

Re: Fabien COELHO 2019-03-22 <alpine.DEB.2.21.1903221514390.2198@lancre>
> Attached is a quick patch about "pg_rewind", so that the control file is
> updated after everything else is committed to disk.

>  	update_controlfile(datadir_target, progname, &ControlFile_new, do_sync);
>  
> -	pg_log(PG_PROGRESS, "syncing target data directory\n");
> -	syncTargetDirectory();

Doesn't the control file still need syncing?

Christoph

view thread (149+ messages)  latest in thread

Message-ID: <20190322153012.GE32388@msg.df7cb.de>
Permalink:  ../20190322153012.GE32388@msg.df7cb.de/
Also on:    postgresql.org/message-id/20190322153012.GE32388@msg.df7cb.de

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: myon@debian.org, coelho@cri.ensmp.fr, michael@paquier.xyz, andres@anarazel.de, michael.banck@credativ.de, magnus@hagander.net, sk@zsrv.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: Offline enabling/disabling of data checksums
  In-Reply-To: <20190322153012.GE32388@msg.df7cb.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox