From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: performance issue in remove_from_unowned_list()
Date: Wed, 27 Mar 2019 03:36:12 +0100
Message-ID: <20190327023612.GC4406@development> (raw)
In-Reply-To: <cdc51a4d-a47c-a514-0db8-a758d3190b4d@2ndquadrant.com>
References: <20190310200923.GA4108@alvherre.pgsql>
<7c599eff-8125-091c-61ef-90e02aa57486@2ndquadrant.com>
<cdc51a4d-a47c-a514-0db8-a758d3190b4d@2ndquadrant.com>
On Thu, Mar 21, 2019 at 02:22:40AM +0100, Tomas Vondra wrote:
> ...
>
>OK, so here is a bit more polished version of the dlist-based patch.
>
>It's almost identical to what I posted before, except that it:
>
>1) undoes the non-working optimization in DropRelationFiles()
>
>2) removes add_to_unowned_list/remove_from_unowned_list entirely and
>just replaces that with dlist_push_tail/dlist_delete
>
>I've originally planned to keep those functions, mostly because the
>remove_from_unowned_list comment says this:
>
> - * If the reln is not present in the list, nothing happens.
> - * Typically this would be caller error, but there seems no
> - * reason to throw an error.
>
>I don't think dlist_delete allows that. But after further inspection of
>all places calling those functions, don't think that can happen.
>
>I plan to commit this soon-ish and backpatch it as mentioned before,
>because I consider it pretty much a fix for b4166911.
>
Aaaaaand committed + backpatched.
>
>--
>Tomas Vondra http://www.2ndQuadrant.com
>PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: performance issue in remove_from_unowned_list()
In-Reply-To: <20190327023612.GC4406@development>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox