pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Jaime Casanova <jaime.casanova@2ndquadrant.com>
Subject: Re: [HACKERS] generated columns
Date: Mon, 1 Apr 2019 22:44:05 +0900
Message-ID: <20190401134405.GG16093@paquier.xyz> (raw)
In-Reply-To: <fe2c53f8-db57-1d58-2d96-c992169a291c@2ndquadrant.com>
References: <a9dcee31-6ae9-f581-f362-a27774cbe156@2ndquadrant.com>
	<20190227073124.GH3540@paquier.xyz>
	<4ebd3319-43df-94b1-4f5c-4149d8bd0031@2ndquadrant.com>
	<CAFj8pRApJQfre4zpAx+PR0KHazqzgJDEB=hG9hmdzt16xoaprw@mail.gmail.com>
	<20190320025103.GG3488@paquier.xyz>
	<d75e0126-8484-3dd9-0193-aa091299b130@2ndquadrant.com>
	<CAFj8pRD3L9pZqrh-2BuBaBHa2A-h3-xAoO0v2dujwaKtfeS1OQ@mail.gmail.com>
	<24577a1a-0216-3094-2360-1ddb2fc6a100@2ndquadrant.com>
	<CAMkU=1xo_NW3h5-+yM=Ph_KHU09hU2mNxuOGtNuhTVZDbLgzzg@mail.gmail.com>
	<fe2c53f8-db57-1d58-2d96-c992169a291c@2ndquadrant.com>

On Mon, Apr 01, 2019 at 10:53:27AM +0200, Peter Eisentraut wrote:
> On 2019-03-31 15:22, Jeff Janes wrote:
>> I can't do a same-major-version pg_upgrade across this commit, as the
>> new pg_dump is trying to dump a nonexistent attgenerated column from the
>> old database.  Is that acceptable collateral damage?  I thought we
>> usually avoided that breakage within the dev branch, but I don't know
>> how we do it.
> 
> We don't.

Really?  I thought on the contrary that it should work.  This reminds
me of commit 59a884e9, which has been discussed here:
https://www.postgresql.org/message-id/20160212001846.GB29511@momjian.us
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (112+ messages)  latest in thread

Message-ID: <20190401134405.GG16093@paquier.xyz>
Permalink:  ../20190401134405.GG16093@paquier.xyz/
Also on:    postgresql.org/message-id/20190401134405.GG16093@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, peter.eisentraut@2ndquadrant.com, jeff.janes@gmail.com, pavel.stehule@gmail.com, sk@zsrv.org, jaime.casanova@2ndquadrant.com
  Subject: Re: [HACKERS] generated columns
  In-Reply-To: <20190401134405.GG16093@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox