From: Andres Freund <andres@anarazel.de>
To: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Asim R P <apraveen@pivotal.io>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Ashwin Agrawal <aagrawal@pivotal.io>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: Pluggable Storage - Andres's take
Date: Mon, 1 Apr 2019 16:18:10 -0700
Message-ID: <20190401231810.arpvmhw66bwsyobj@alap3.anarazel.de> (raw)
In-Reply-To: <CAJrrPGeUqNy0BxWuDd1n5cLQoWUwQ5jhKnDQ6Ty3wt=KsyOoPQ@mail.gmail.com>
References: <CAJrrPGd+rkz54wE-oXRojg4XwC3bcF6bjjRziD+XhFup9Q3n2w@mail.gmail.com>
<20190309031825.zlgqs3tg424g3lkf@alap3.anarazel.de>
<CAJrrPGcwaAtaRF9dOfSi0unTLU9WyD+Z9jQ8h0exE0kHu9V1dw@mail.gmail.com>
<20190312.172757.17614556.horiguchi.kyotaro@lab.ntt.co.jp>
<CAJrrPGeUqNy0BxWuDd1n5cLQoWUwQ5jhKnDQ6Ty3wt=KsyOoPQ@mail.gmail.com>
Hi,
On 2019-03-16 23:21:31 +1100, Haribabu Kommi wrote:
> updated patches are attached.
Now that nearly all of the tableam patches are committed (with the
exception of the copy.c changes which are for bad reasons discussed at
[1]) I'm looking at the docs changes.
What made you rename indexam.sgml to am.sgml, instead of creating a
separate tableam.sgml? Seems easier to just have a separate file?
I'm currently not planning to include the function-by-function API
reference you've in your patchset, as I think it's more reasonable to
centralize all of it in tableam.h. I think I've included most of the
information there - could you check whether you agree?
[1] https://postgr.es/m/CAKJS1f98Fa%2BQRTGKwqbtz0M%3DCy1EHYR8Q-W08cpA78tOy4euKQ%40mail.gmail.com
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andres@anarazel.de, kommi.haribabu@gmail.com, horiguchi.kyotaro@lab.ntt.co.jp, alvherre@2ndquadrant.com, david.rowley@2ndquadrant.com, robertmhaas@gmail.com, apraveen@pivotal.io, aagrawal@pivotal.io, 9erthalion6@gmail.com, a.korotkov@postgrespro.ru, hlinnaka@iki.fi
Subject: Re: Pluggable Storage - Andres's take
In-Reply-To: <20190401231810.arpvmhw66bwsyobj@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox