pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Asim R P <apraveen@pivotal.io>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Ashwin Agrawal <aagrawal@pivotal.io>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: Pluggable Storage - Andres's take
Date: Mon, 1 Apr 2019 17:53:52 -0700
Message-ID: <20190402005352.64hk76gddvs36uwl@alap3.anarazel.de> (raw)
In-Reply-To: <CAJrrPGfSEeqdZve2X8zkRo2Bm=M-bQf8WiJEMBshVvtrZjO0Gg@mail.gmail.com>
References: <CAJrrPGd+rkz54wE-oXRojg4XwC3bcF6bjjRziD+XhFup9Q3n2w@mail.gmail.com>
	<20190309031825.zlgqs3tg424g3lkf@alap3.anarazel.de>
	<CAJrrPGcwaAtaRF9dOfSi0unTLU9WyD+Z9jQ8h0exE0kHu9V1dw@mail.gmail.com>
	<20190312.172757.17614556.horiguchi.kyotaro@lab.ntt.co.jp>
	<CAJrrPGeUqNy0BxWuDd1n5cLQoWUwQ5jhKnDQ6Ty3wt=KsyOoPQ@mail.gmail.com>
	<20190401231810.arpvmhw66bwsyobj@alap3.anarazel.de>
	<CAJrrPGfSEeqdZve2X8zkRo2Bm=M-bQf8WiJEMBshVvtrZjO0Gg@mail.gmail.com>

Hi,

On 2019-04-02 11:39:57 +1100, Haribabu Kommi wrote:
> > What made you rename indexam.sgml to am.sgml, instead of creating a
> > separate tableam.sgml?  Seems easier to just have a separate file?
> >
> 
> No specific reason, I just thought of adding all the access methods under
> one file.
> I can change it to tableam.sgml.

I'd rather keep it separate. It seems likely that both table and indexam
docs will grow further over time, and they're not that closely
related. Additionally not moving sect1->sect2 etc will keep links stable
(which we could also achieve with different sect1 names, I realize
that).

> I can understand your point of avoiding function-by-function API reference,
> as the user can check directly the code comments, Still I feel some people
> may refer the doc for API changes. I am fine to remove based on your
> opinion.

I think having to keeping both tableam.h and the sgml file current is
too much overhead - and anybody that's going to create a new tableam is
going to be able to look into the source anyway.

Greetings,

Andres Freund





view thread (175+ messages)  latest in thread

Message-ID: <20190402005352.64hk76gddvs36uwl@alap3.anarazel.de>
Permalink:  ../20190402005352.64hk76gddvs36uwl@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20190402005352.64hk76gddvs36uwl@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andres@anarazel.de, kommi.haribabu@gmail.com, horiguchi.kyotaro@lab.ntt.co.jp, alvherre@2ndquadrant.com, david.rowley@2ndquadrant.com, robertmhaas@gmail.com, apraveen@pivotal.io, aagrawal@pivotal.io, 9erthalion6@gmail.com, a.korotkov@postgrespro.ru, hlinnaka@iki.fi
  Subject: Re: Pluggable Storage - Andres's take
  In-Reply-To: <20190402005352.64hk76gddvs36uwl@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox