From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Shawn Debnath <sdn@amazon.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Refactoring the checkpointer's fsync request queue
Date: Thu, 4 Apr 2019 10:02:58 -0300
Message-ID: <20190404130258.GA7320@alvherre.pgsql> (raw)
In-Reply-To: <CA+hUKGLRWQTZwUC0vdiPs=RYu8B+2g7VJFaV0iP6cUFbKheHug@mail.gmail.com>
On 2019-Apr-04, Thomas Munro wrote:
> I don't think it's project policy to put a single typedef into its own
> header like that, and I'm not sure where else to put it.
shrug. Looks fine to me. I suppose if we don't have it anywhere, it's
just because we haven't needed that particular trick yet. Creating a
file with a lone typedef seems better than using uint32 to me.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, thomas.munro@gmail.com, sdn@amazon.com, andres@anarazel.de, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, 9erthalion6@gmail.com
Subject: Re: Refactoring the checkpointer's fsync request queue
In-Reply-To: <20190404130258.GA7320@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox