From: Shawn Debnath <sdn@amazon.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Refactoring the checkpointer's fsync request queue
Date: Fri, 5 Apr 2019 09:22:06 -0700
Message-ID: <20190405162206.GA23763@f01898859afd.ant.amazon.com> (raw)
In-Reply-To: <CA+hUKGLO9njPo0J0UEjTQLgzmE_w37iK=WoZRj0zT+3R2S7Mig@mail.gmail.com>
References: <CA+hUKGLRWQTZwUC0vdiPs=RYu8B+2g7VJFaV0iP6cUFbKheHug@mail.gmail.com>
<20190404130258.GA7320@alvherre.pgsql>
<CA+hUKGLO9njPo0J0UEjTQLgzmE_w37iK=WoZRj0zT+3R2S7Mig@mail.gmail.com>
On Fri, Apr 05, 2019 at 10:53:53AM +1300, Thomas Munro wrote:
> On Fri, Apr 5, 2019 at 2:03 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > On 2019-Apr-04, Thomas Munro wrote:
> > > I don't think it's project policy to put a single typedef into its own
> > > header like that, and I'm not sure where else to put it.
> >
> > shrug. Looks fine to me. I suppose if we don't have it anywhere, it's
> > just because we haven't needed that particular trick yet. Creating a
> > file with a lone typedef seems better than using uint32 to me.
>
> It was commit 9fac5fd7 that gave me that idea.
>
> Ok, here is a patch that adds a one-typedef header and uses
> SegmentIndex to replace all cases of BlockNumber and int holding a
> segment number (where as an "index" or a "count").
Looks good to me.
--
Shawn Debnath
Amazon Web Services (AWS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sdn@amazon.com, thomas.munro@gmail.com, alvherre@2ndquadrant.com, andres@anarazel.de, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, 9erthalion6@gmail.com
Subject: Re: Refactoring the checkpointer's fsync request queue
In-Reply-To: <20190405162206.GA23763@f01898859afd.ant.amazon.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox