From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Daniel Verite <daniel@manitou-mail.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Cleanup/remove/update references to OID column
Date: Wed, 17 Apr 2019 19:42:19 -0500
Message-ID: <20190418004219.GJ2854@telsasoft.com> (raw)
In-Reply-To: <20190418002347.rlqmypv5prlpl2bg@alap3.anarazel.de>
References: <20190408002847.GA904@telsasoft.com>
<da5a314d-f92d-47ef-b005-8451f26de0f2@manitou-mail.org>
<20190410165917.GD10080@telsasoft.com>
<20190418002347.rlqmypv5prlpl2bg@alap3.anarazel.de>
On Wed, Apr 17, 2019 at 05:23:47PM -0700, Andres Freund wrote:
> Thanks for the patch!
Thanks for fixing it up and commiting.
Would you consider the remaining two hunks, attached ?
Justin
Attachments:v3-0001-Cleanup-remove-update-references-to-OID-column.patch (text/x-diff, 2.1K) download
From fcd6279d0681093e8741cc5a05879afc95751c40 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj@telsasoft.com>
Date: Tue, 2 Apr 2019 19:13:55 -0500
Subject: [PATCH v3] Cleanup/remove/update references to OID column...
..in wake of 578b229718e8f.
See also
93507e67c9ca54026019ebec3026de35d30370f9
1464755fc490a9911214817fe83077a3689250ab
Author: Justin Pryzby <justin@telsasoft.com>
Author: Daniel Verite <daniel@manitou-mail.org>
---
doc/src/sgml/information_schema.sgml | 4 ++--
doc/src/sgml/ref/insert.sgml | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/src/sgml/information_schema.sgml b/doc/src/sgml/information_schema.sgmlindex 234a3bb..9c618b1 100644--- a/doc/src/sgml/information_schema.sgml+++ b/doc/src/sgml/information_schema.sgml@@ -1312,8 +1312,8 @@
<para>
The view <literal>columns</literal> contains information about all
table columns (or view columns) in the database. System columns
- (<literal>ctid</literal>, etc.) are not included. Only those columns are- shown that the current user has access to (by way of being the+ (<literal>ctid</literal>, etc.) are not included. The only columns shown+ are those to which the current user has access (by way of being the
owner or having some privilege).
</para>
diff --git a/doc/src/sgml/ref/insert.sgml b/doc/src/sgml/ref/insert.sgmlindex 189ce2a..f995a76 100644--- a/doc/src/sgml/ref/insert.sgml+++ b/doc/src/sgml/ref/insert.sgml@@ -554,7 +554,7 @@ INSERT <replaceable>oid</replaceable> <replaceable class="parameter">count</repl
The <replaceable class="parameter">count</replaceable> is the number of
rows inserted or updated. <replaceable>oid</replaceable> is always 0 (it
used to be the <acronym>OID</acronym> assigned to the inserted row if
- <replaceable>rows</replaceable> was exactly one and the target table was+ <replaceable>count</replaceable> was exactly one and the target table was
declared <literal>WITH OIDS</literal> and 0 otherwise, but creating a table
<literal>WITH OIDS</literal> is not supported anymore).
</para>
--
2.7.4
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, andres@anarazel.de, daniel@manitou-mail.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Cleanup/remove/update references to OID column
In-Reply-To: <20190418004219.GJ2854@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox