From: Noah Misch <noah@leadboat.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: 9erthalion6@gmail.com <9erthalion6@gmail.com>
Cc: sfrost@snowman.net <sfrost@snowman.net>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid
Date: Sun, 28 Apr 2019 10:00:11 -0700
Message-ID: <20190428170011.GC200983@rfd.leadboat.com> (raw)
In-Reply-To: <GrdLgAdUK9FdyZg8VIcTDKVOkys122ZINEb3CjjoySfGj2KyPiMKTh1zqtRp0TAD7FJ27G-OBB3eplxIB5GhcQH5o8zzGZfp0MuJaXJxVxk=@yesql.se>
References: <CA+q6zcV4r+oS27G-nYqonG+q7442BOA350s3jeRtA-Oqx4vDWg@mail.gmail.com>
<20181130065140.GB2774301@rfd.leadboat.com>
<20181203004106.GA2860387@rfd.leadboat.com>
<20190304.180420.139624607.horiguchi.kyotaro@lab.ntt.co.jp>
<20190307032422.GB1797215@rfd.leadboat.com>
<20190309071610.GA2039121@rfd.leadboat.com>
<GrdLgAdUK9FdyZg8VIcTDKVOkys122ZINEb3CjjoySfGj2KyPiMKTh1zqtRp0TAD7FJ27G-OBB3eplxIB5GhcQH5o8zzGZfp0MuJaXJxVxk=@yesql.se>
On Fri, Mar 29, 2019 at 09:53:51AM +0000, Daniel Gustafsson wrote:
> On Saturday, March 9, 2019 8:16 AM, Noah Misch <noah@leadboat.com> wrote:
> > I tested on Red Hat and on Windows Server 2016; I won't be shocked
> > if the test (not the code under test) breaks on other Windows configurations.
>
> IIRC there are Windows versions where Win32::Process::KillProcess is required
> for this, but thats admittedly somewhat dated knowledge. If the buildfarm goes
> red on older Windows animals it might be something to look at perhaps.
Since my second attempt at committing this (commit c098509), I fixed these
bugs in the new test file:
- MSYS-orchestrated mingw32 (buildfarm member jacana) failed the Perl kill(9,
...) calls[1]. For HEAD and v11, using "pg_ctl kill KILL <pid>" fixed that.
For v10 and v9.6, I disabled the test under msys. I can reproduce this with
Perl 5.28 from msys2. Its kill(9, ...) fails for any non-msys2 process (any
ordinary Windows process). [commits 947a350, 2bc0474]
- The regress.dll path needed MSYS-to-w32 path translation. [commit 9daefff]
- The changes to port selection in get_new_node() made Linux-specific
assumptions, so Windows builds had much less protection against port
conflict. [commit 4ab02e8]
- Got EPIPE when writing to stdin of a child process that exited too quickly.
[commit e12a472]
Things have been stable on the buildfarm for the last twelve days, so I think
this one is over.
[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2019-04-13%2014%3A39%3A17
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, daniel@yesql.se, horiguchi.kyotaro@lab.ntt.co.jp, 9erthalion6@gmail.com, sfrost@snowman.net
Subject: Re: [HACKERS] Weaker shmem interlock w/o postmaster.pid
In-Reply-To: <20190428170011.GC200983@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox