From: Justin Pryzby <pryzby@telsasoft.com>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: doc: improve PG 12 to_timestamp()/to_date() wording
Date: Tue, 30 Apr 2019 19:14:04 -0500
Message-ID: <20190501001403.GN3925@telsasoft.com> (raw)
In-Reply-To: <CAPpHfduhdg+bXjzg9nbpk-ZrCsNP3QFvRv33Vmi+k3_TjwftXA@mail.gmail.com>
References: <20190430183636.GA8175@telsasoft.com>
<CAPpHfduhdg+bXjzg9nbpk-ZrCsNP3QFvRv33Vmi+k3_TjwftXA@mail.gmail.com>
On Tue, Apr 30, 2019 at 09:48:14PM +0300, Alexander Korotkov wrote:
> I'd like to add couple of comments from my side.
> > - returns an error because the second template string space is consumed
> > - by the letter <literal>J</literal> in the input string.
> > + returns an error because the second space in the template string consumes
> > + the letter <literal>M</literal> from the input string.
>
> Why <literal>M</literal>? There is no letter "M" is input string.
> The issue here is that we already consumed "J" from "JUN" and trying
> to match "UN" to "MON". So, I think we should live
> <literal>J</literal> here. The rest of this change looks good.
Seems like I confused myself while resolving rebase conflict.
Thanks for checking.
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, a.korotkov@postgrespro.ru, bruce@momjian.us, pgsql-hackers@lists.postgresql.org
Subject: Re: doc: improve PG 12 to_timestamp()/to_date() wording
In-Reply-To: <20190501001403.GN3925@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox