From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: David Fetter <david@fetter.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Development <pgsql-hackers@postgresql.org>
Subject: Re: New EXPLAIN option: ALL
Date: Wed, 15 May 2019 11:05:31 -0400
Message-ID: <20190515150531.GA12534@alvherre.pgsql> (raw)
In-Reply-To: <20190513055112.GA24409@fetter.org>
On 2019-May-13, David Fetter wrote:
> I tried changing it to EXEC (EXPLAIN EXECUTE is already a thing), but
> got a giant flock of reduce-reduce conflicts along with a few
> shift-reduce conflicts.
After eyeballing the giant patch set you sent[1], I think EXEC is a
horrible keyword to use -- IMO it should either be the complete word
EXECUTE, or we should pick some other word. I realize that we do not
want to have different sets of keywords when using the legacy syntax (no
parens) vs. new-style (with parens), but maybe we should just not
support the EXECUTE keyword in the legacy syntax; there's already a
number of options we don't support in the legacy syntax (BUFFERS,
TIMING), so this isn't much of a stretch.
IOW if we want to change ANALYZE to EXECUTE, I propose we change it in
the new-style syntax only and not the legacy one. So:
EXPLAIN ANALYZE SELECT ... -- legacy syntax
EXPLAIN (EXECUTE) SELECT ... -- new-style
EXPLAIN (ANALYZE) SELECT ... -- we still support ANALYZE as an alias, for compatibility
this should not cause a conflict with EXPLAIN EXECUTE, so these all
should work:
EXPLAIN ANALYZE EXECUTE ...
EXPLAIN (EXECUTE) EXECUTE ...
EXPLAIN (ANALYZE) EXECUTE ...
[1] I think if you just leave out the GUC print from the changes, it
becomes a reasonable patch series.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, david@fetter.org, tgl@sss.pgh.pa.us, sfrost@snowman.net, andres@anarazel.de
Subject: Re: New EXPLAIN option: ALL
In-Reply-To: <20190515150531.GA12534@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox