pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedpg_checksums has an untranslatable string.
4+ messages / 3 participants
[nested] [flat]
* pg_checksums has an untranslatable string.
@ 2019-06-06 09:55 Horiguchi Kyotaro <horikyota.ntt@gmail.com>
0 siblings, 0 replies; 4+ messages in thread
From: Horiguchi Kyotaro @ 2019-06-06 09:55 UTC (permalink / raw)
To: pgsql-hackers@lists.postgresql.org
Hello.
# My email address has changed.
I found a string that ought to be translatable but actually not,
in pg_checksums.c.
> fprintf(stderr, "%*s/%s MB (%d%%) computed",
It seems to be the only instance in the file.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
[application/octet-stream] pg_checksums_fix_untranslatable_string.patch (545B, ../../CAKPRHzKvbND4wabVJ=+=KRPhN1p2_5TPsyQwFatg6jV6h2ic3w@mail.gmail.com/3-pg_checksums_fix_untranslatable_string.patch)
download | inline diff:
diff --git a/src/bin/pg_checksums/pg_checksums.c b/src/bin/pg_checksums/pg_checksums.c
index 1d75aa0282..7c7a75cdcd 100644
--- a/src/bin/pg_checksums/pg_checksums.c
+++ b/src/bin/pg_checksums/pg_checksums.c
@@ -146,7 +146,7 @@ progress_report(bool force)
snprintf(current_size_str, sizeof(current_size_str), INT64_FORMAT,
current_size / (1024 * 1024));
- fprintf(stderr, "%*s/%s MB (%d%%) computed",
+ fprintf(stderr, _("%*s/%s MB (%d%%) computed"),
(int) strlen(current_size_str), current_size_str, total_size_str,
percent);
^ permalink raw reply [nested|flat] 4+ messages in thread
* pg_checksums has an untranslatable string.
@ 2019-06-06 11:06 Kyotaro Horiguchi <horikyota.ntt@gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Kyotaro Horiguchi @ 2019-06-06 11:06 UTC (permalink / raw)
To: pgsql-hackers@lists.postgresql.org
Hello.
# My email address has changed. Apologize in advance for possible
# duplicate of this mail because this is the seconf try after
# mail server seems to have failed the first try...
I found a string that ought to be translatable but actually not,
in pg_checksums.c.
> fprintf(stderr, "%*s/%s MB (%d%%) computed",
It seems to be the only instance in the file.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
[text/x-patch] pg_checksums_fix_untranslatable_string.patch (544B, ../../20190606.200612.110313249.horikyota.ntt@gmail.com/2-pg_checksums_fix_untranslatable_string.patch)
download | inline diff:
diff --git a/src/bin/pg_checksums/pg_checksums.c b/src/bin/pg_checksums/pg_checksums.c
index 1d75aa0282..7c7a75cdcd 100644
--- a/src/bin/pg_checksums/pg_checksums.c
+++ b/src/bin/pg_checksums/pg_checksums.c
@@ -146,7 +146,7 @@ progress_report(bool force)
snprintf(current_size_str, sizeof(current_size_str), INT64_FORMAT,
current_size / (1024 * 1024));
- fprintf(stderr, "%*s/%s MB (%d%%) computed",
+ fprintf(stderr, _("%*s/%s MB (%d%%) computed"),
(int) strlen(current_size_str), current_size_str, total_size_str,
percent);
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pg_checksums has an untranslatable string.
@ 2019-06-06 13:11 Michael Paquier <michael@paquier.xyz>
parent: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Michael Paquier @ 2019-06-06 13:11 UTC (permalink / raw)
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>; +Cc: pgsql-hackers@lists.postgresql.org
On Thu, Jun 06, 2019 at 08:06:12PM +0900, Kyotaro Horiguchi wrote:
> It seems to be the only instance in the file.
Confirmed and committed. Thanks for the report.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../20190606131158.GA1978@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pg_checksums has an untranslatable string.
@ 2019-06-07 00:46 Horiguchi Kyotaro <horikyota.ntt@gmail.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 4+ messages in thread
From: Horiguchi Kyotaro @ 2019-06-07 00:46 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-hackers@lists.postgresql.org
Hello
> Confirmed and committed. Thanks for the report.
Thanks for committing.
--
Kyotaro Horiguchi
NTT Open Source Software Center
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2019-06-07 00:46 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-06-06 09:55 pg_checksums has an untranslatable string. Horiguchi Kyotaro <horikyota.ntt@gmail.com>
2019-06-06 11:06 pg_checksums has an untranslatable string. Kyotaro Horiguchi <horikyota.ntt@gmail.com>
2019-06-06 13:11 ` Michael Paquier <michael@paquier.xyz>
2019-06-07 00:46 ` Horiguchi Kyotaro <horikyota.ntt@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox