pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Subject: pg_checksums has an untranslatable string.
Date: Thu, 06 Jun 2019 20:06:12 +0900 (Tokyo Standard Time)
Message-ID: <20190606.200612.110313249.horikyota.ntt@gmail.com> (raw)

Hello.

# My email address has changed. Apologize in advance for possible
# duplicate of this mail because this is the seconf try after
# mail server seems to have failed the first try...

I found a string that ought to be translatable but actually not,
in pg_checksums.c.

>  fprintf(stderr, "%*s/%s MB (%d%%) computed",

It seems to be the only instance in the file.

regards.
-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Attachments:

  [text/x-patch] pg_checksums_fix_untranslatable_string.patch (544B, ../20190606.200612.110313249.horikyota.ntt@gmail.com/2-pg_checksums_fix_untranslatable_string.patch)
  download | inline diff:
diff --git a/src/bin/pg_checksums/pg_checksums.c b/src/bin/pg_checksums/pg_checksums.c
index 1d75aa0282..7c7a75cdcd 100644
--- a/src/bin/pg_checksums/pg_checksums.c
+++ b/src/bin/pg_checksums/pg_checksums.c
@@ -146,7 +146,7 @@ progress_report(bool force)
 	snprintf(current_size_str, sizeof(current_size_str), INT64_FORMAT,
 			 current_size / (1024 * 1024));
 
-	fprintf(stderr, "%*s/%s MB (%d%%) computed",
+	fprintf(stderr, _("%*s/%s MB (%d%%) computed"),
 			(int) strlen(current_size_str), current_size_str, total_size_str,
 			percent);
 

view thread (4+ messages)  latest in thread

Message-ID: <20190606.200612.110313249.horikyota.ntt@gmail.com>
Permalink:  ../20190606.200612.110313249.horikyota.ntt@gmail.com/
Also on:    postgresql.org/message-id/20190606.200612.110313249.horikyota.ntt@gmail.com

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: horikyota.ntt@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: pg_checksums has an untranslatable string.
  In-Reply-To: <20190606.200612.110313249.horikyota.ntt@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox