pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Daniel Verite <daniel@manitou-mail.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Cleanup/remove/update references to OID column
Date: Mon, 1 Jul 2019 10:59:32 -0500
Message-ID: <20190701155932.GA22866@telsasoft.com> (raw)
In-Reply-To: <20190508190557.GD3925@telsasoft.com>
References: <20190408002847.GA904@telsasoft.com>
	<da5a314d-f92d-47ef-b005-8451f26de0f2@manitou-mail.org>
	<20190410165917.GD10080@telsasoft.com>
	<20190418002347.rlqmypv5prlpl2bg@alap3.anarazel.de>
	<20190418004219.GJ2854@telsasoft.com>
	<20190418005115.r4mat75wvlski3ij@alap3.anarazel.de>
	<20190508190557.GD3925@telsasoft.com>

I'm resending this patch, which still seems to be needed.

Also, should this be removed ?  Or at leat remove the parenthesized text, since
non-system tables no longer have OIDs: "(use to avoid output on system tables)"

https://www.postgresql.org/docs/devel/runtime-config-developer.html
trace_lock_oidmin (integer)

And maybe this (?)
trace_lock_table (integer)

On Wed, May 08, 2019 at 02:05:57PM -0500, Justin Pryzby wrote:
> I found what appears to be a dangling reference to old "hidden" OID behavior.
> 
> Justin

> From 1c6712c0ade949648dbc415dfd7ea80312360ef7 Mon Sep 17 00:00:00 2001
> From: Justin Pryzby <pryzbyj@telsasoft.com>
> Date: Wed, 8 May 2019 13:57:12 -0500
> Subject: [PATCH v1] Cleanup/remove/update references to OID column...
> 
> ..in wake of 578b229718e8f.
> 
> See also
> 93507e67c9ca54026019ebec3026de35d30370f9
> 1464755fc490a9911214817fe83077a3689250ab
> f6b39171f3d65155b9390c2c69bc5b3469f923a8
> 
> Author: Justin Pryzby <justin@telsasoft.com>
> ---
>  doc/src/sgml/catalogs.sgml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
> index d544e60..0f9c6f2 100644
> --- a/doc/src/sgml/catalogs.sgml
> +++ b/doc/src/sgml/catalogs.sgml
> @@ -610,7 +610,7 @@
>        <entry><structfield>oid</structfield></entry>
>        <entry><type>oid</type></entry>
>        <entry></entry>
> -      <entry>Row identifier (hidden attribute; must be explicitly selected)</entry>
> +      <entry>Row identifier</entry>
>       </row>
>  
>       <row>
> -- 
> 2.7.4
> 


-- 
Justin Pryzby
System Administrator
Telsasoft
+1-952-707-8581





view thread (19+ messages)  latest in thread

Message-ID: <20190701155932.GA22866@telsasoft.com>
Permalink:  ../20190701155932.GA22866@telsasoft.com/
Also on:    postgresql.org/message-id/20190701155932.GA22866@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, andres@anarazel.de, daniel@manitou-mail.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: Cleanup/remove/update references to OID column
  In-Reply-To: <20190701155932.GA22866@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox