From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Dmitry Belyavsky <beldmit@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Nikolay Shaplov <dhyan@nataraj.su>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Ltree syntax improvement
Date: Mon, 8 Jul 2019 16:16:34 -0400
Message-ID: <20190708201634.GA17499@alvherre.pgsql> (raw)
In-Reply-To: <CADqLbz+gUmusJYivWCqFt=LgEXsX5OUQBKZXQDDx4b3dtA23MQ@mail.gmail.com>
On 2019-Jul-08, Dmitry Belyavsky wrote:
> Dear Thomas,
>
> Thank you for your proofreading!
>
> Please find the updated patch attached. It also contains the missing
> escaping.
I think all these functions you're adding should have a short sentence
explaining what it does.
I'm not really convinced that we need this much testing. It seems a bit
excessive. Many of these very focused test SQL lines could be removed
with no loss of coverage, and many of the others could be grouped into
one.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, beldmit@gmail.com, thomas.munro@gmail.com, dhyan@nataraj.su, pgsql-hackers@lists.postgresql.org
Subject: Re: Ltree syntax improvement
In-Reply-To: <20190708201634.GA17499@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox