pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: David Fetter <david@fetter.org>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Oleksandr Shulgin <oleksandr.shulgin@zalando.de>
Cc: Artur Zakirov <a.zakirov@postgrespro.ru>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Oleg Bartunov <obartunov@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: David Steele <david@pgmasters.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] [PATCH] Generic type subscripting
Date: Thu, 11 Jul 2019 16:33:18 +0200
Message-ID: <20190711143318.GL24679@fetter.org> (raw)
In-Reply-To: <CA+q6zcUJTtp_GxnX+Q7Zo5RMk+12Tw-rsqLGnh+76hzJ3MH5LA@mail.gmail.com>
References: <CA+q6zcXnesTL5ALJ+_M6gmP+7ehBL9eMJqy25hhD3Gx44AOCpw@mail.gmail.com>
	<CA+q6zcWtU3Vopo3xbmyVazQBjhqj5CfAy7MTEuwmi46s2fq5AA@mail.gmail.com>
	<CAFj8pRBhHabV06m_-n6qjmR-BQC=+t740EJs4Gu5Ck0jzNQMhQ@mail.gmail.com>
	<CA+q6zcW+n0q7NVvYi2rHxcME2OXnL4V7zQRLvKkiETGB8Nxvag@mail.gmail.com>
	<CA+q6zcU=CiNNo45m40sSGRLa6AGEuBUdEiqN8NUyA+A5QYFXbg@mail.gmail.com>
	<CA+q6zcU0wS3edY2b+dQMU4qwBiQ=6-x_mwDRAp5U-a6NvHj0cA@mail.gmail.com>
	<CA+hUKGKj6sSu7+a_u4S7uHV_4aFiN5Es+mz1jn0nYFZErX71qA@mail.gmail.com>
	<CA+q6zcV3bzfSRfWu4pFich46evryijX3ELFV_zm=kPg7KALaOQ@mail.gmail.com>
	<20190711074723.GK24679@fetter.org>
	<CA+q6zcUJTtp_GxnX+Q7Zo5RMk+12Tw-rsqLGnh+76hzJ3MH5LA@mail.gmail.com>

On Thu, Jul 11, 2019 at 04:30:46PM +0200, Dmitry Dolgov wrote:
> > On Thu, Jul 11, 2019 at 9:47 AM David Fetter <david@fetter.org> wrote:
> >
> > Looks great!
> >
> > The tutorial piece has bit-rotted slightly. Please find attached a
> > patch atop yours that fixes it.
> 
> Indeed, I've missed this change, thank you! Although there supposed to be an
> upperindex, not numupper (since the latter is just a number of upper indexes).

Oops! Fooled by a suggestion from the compiler. My bad for not
checking more carefully. Thanks for making this happen.

Best,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate





view thread (276+ messages)  latest in thread

Message-ID: <20190711143318.GL24679@fetter.org>
Permalink:  ../20190711143318.GL24679@fetter.org/
Also on:    postgresql.org/message-id/20190711143318.GL24679@fetter.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: david@fetter.org, 9erthalion6@gmail.com, thomas.munro@gmail.com, pavel.stehule@gmail.com, alvherre@2ndquadrant.com, thomas.munro@enterprisedb.com, oleksandr.shulgin@zalando.de, a.zakirov@postgrespro.ru, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andres@anarazel.de, michael.paquier@gmail.com, obartunov@gmail.com, peter.eisentraut@2ndquadrant.com, david@pgmasters.net
  Subject: Re: [HACKERS] [PATCH] Generic type subscripting
  In-Reply-To: <20190711143318.GL24679@fetter.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox