pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Ildar Musin <i.musin@postgrespro.ru>
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
Date: Fri, 2 Aug 2019 21:54:38 +0200
Message-ID: <20190802195438.4vuotpz6pdq6r6jg@development> (raw)
In-Reply-To: <CAKJS1f-MBwNBQWn=pMrhuk=k=9Hmw8BPAC5ryuX0fXdNMqeiFg@mail.gmail.com>
References: <20190501162021.q7r5cys6uwdb5bsp@alap3.anarazel.de>
	<25570.1556728681@sss.pgh.pa.us>
	<20481181556734692@sas2-80c42a3bfdfe.qloud-c.yandex.net>
	<CAKJS1f9Gaor9+wGWFwaSrm1=N5cPHiM=LGWcCDeuPymC5dkyhw@mail.gmail.com>
	<19795.1556759294@sss.pgh.pa.us>
	<CAKJS1f9dYoeqqOwXW4wqD8tVGNki2AjzOQy=Xo=a_nNAMdYD=g@mail.gmail.com>
	<CAKJS1f-Y2CAV7y_Vay_bmE=oyZPgtm2qXRinozYOJ0SeopjYtw@mail.gmail.com>
	<CAKJS1f_3qanbQSJ8ndkkxCAuHuByJLXR6zuQetOmnmBzWbHg3Q@mail.gmail.com>
	<10303161560180908@sas1-fb8a605c4548.qloud-c.yandex.net>
	<CAKJS1f-MBwNBQWn=pMrhuk=k=9Hmw8BPAC5ryuX0fXdNMqeiFg@mail.gmail.com>

On Wed, Jun 12, 2019 at 08:34:57AM +1200, David Rowley wrote:
>On Tue, 11 Jun 2019 at 03:35, Sergei Kornilov <sk@zsrv.org> wrote:
>> > Does anyone think we shouldn't change the INFO message in ATTACH
>> > PARTITION to a DEBUG1 in PG12?
>>
>> Seems no one wants to vote against this change.
>
>I'm concerned about two things:
>
>1. The patch reduces the test coverage of ATTACH PARTITION. We now
>have no way to ensure the constraint was used to validate the rows in
>the partition.
>2. We're inconsistent with what we do for SET NOT NULL and ATTACH
>PARTITION. We raise an INFO message when we use a constraint for
>ATTACH PARTITION and only a DEBUG1 for SET NOT NULL.
>
>Unfortunately, my two concerns conflict with each other.
>

We're getting close to beta3/rc1, and this thread was idle for ~1 month.

I think there's a consensus to change INFO to DEBUG1 in pg12, and then
maybe imlpement something like VERBOSE mode in the future. Objections?

As for the reduction of test coverage, can't we deduce whether a
constraint was used from data in pg_stats or something like that?

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services 





view thread (73+ messages)  latest in thread

Message-ID: <20190802195438.4vuotpz6pdq6r6jg@development>
Permalink:  ../20190802195438.4vuotpz6pdq6r6jg@development/
Also on:    postgresql.org/message-id/20190802195438.4vuotpz6pdq6r6jg@development

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, david.rowley@2ndquadrant.com, sk@zsrv.org, tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com, david@pgmasters.net, alvherre@alvh.no-ip.org, sfrost@snowman.net, i.musin@postgrespro.ru
  Subject: Re: using index or check in ALTER TABLE SET NOT NULL
  In-Reply-To: <20190802195438.4vuotpz6pdq6r6jg@development>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox