From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ian Barwick <ian.barwick@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
Date: Wed, 14 Aug 2019 17:15:20 -0400
Message-ID: <20190814211520.GK16436@tamriel.snowman.net> (raw)
In-Reply-To: <29770.1565810142@sss.pgh.pa.us>
References: <30823.1565030571@sss.pgh.pa.us>
<CA+TgmobRpgiqCZ_FMUeDW4RM1W+RzT4HA2xSQy=QMcfv=X47jw@mail.gmail.com>
<32103.1565032053@sss.pgh.pa.us>
<20190806005225.GM29202@tamriel.snowman.net>
<6cba0dff-485b-6781-d659-0a376b966c89@2ndquadrant.com>
<20190806021616.GP29202@tamriel.snowman.net>
<54620b18-60b7-4b9b-7d1d-90a6464ab333@2ndquadrant.com>
<5879.1565121423@sss.pgh.pa.us>
<20190806214355.GA29202@tamriel.snowman.net>
<29770.1565810142@sss.pgh.pa.us>
Greetings,
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > * Tom Lane (tgl@sss.pgh.pa.us) wrote:
> >> Perhaps we could put some of these details into the Notes section of the
> >> ALTER SYSTEM ref page. But I wonder how much of this is needed at all.
>
> > I'd be alright with that too, but I'd be just as fine with even a README
> > or something that we feel other hackers and external tool developers
> > would be likely to find. I agree that all of this isn't something that
> > your run-of-the-mill DBA needs to know, but they are things that I'm
> > sure external tool authors will care about (including myself, David S,
> > probably the other backup/restore tool maintainers, and at least the
> > author of pg_conftool, presumably).
>
> In hopes of moving this along, I've pushed Ian's last code change,
> as there seems to be no real argument about that anymore.
>
> As for the doc changes, how about the attached revision of what
> I wrote previously? It gives some passing mention to what ALTER
> SYSTEM will do, without belaboring it or going into things that
> are really implementation details.
It's certainly better than what we have now.
> As an example of the sort of implementation detail that I *don't*
> want to document, I invite you to experiment with the difference
> between
> ALTER SYSTEM SET TimeZone = 'America/New_York';
> ALTER SYSTEM SET "TimeZone" = 'America/New_York';
Implementation details and file formats / acceptable transformations
are naturally different things- a given implementation may sort things
one way or another but if there's no requirement that the file be sorted
then that's just fine and can be an implementation detail possibly based
around how duplicates are dealt with.
Thanks,
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us, ian.barwick@2ndquadrant.com, robertmhaas@gmail.com, tomas.vondra@2ndquadrant.com, amit.kapila16@gmail.com
Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
In-Reply-To: <20190814211520.GK16436@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox