pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Abhijit Menon-Sen <ams@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Pavan Deolasee <pavan.deolasee@2ndquadrant.com>
Subject: Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
Date: Thu, 5 Sep 2019 10:41:31 +0900
Message-ID: <20190905014131.GD14853@paquier.xyz> (raw)
In-Reply-To: <20190904205045.GA14613@alvherre.pgsql>
References: <20190904194629.GA12433@alvherre.pgsql>
	<20190904205045.GA14613@alvherre.pgsql>

On Wed, Sep 04, 2019 at 04:50:45PM -0400, Alvaro Herrera wrote:
> According to CFbot, the Windows build fails with this patch.  Please
> fix.

To save a couple of clicks:
"C:\projects\postgresql\pageinspect.vcxproj" (default target) (56) ->
(Link target) ->
  heapfuncs.obj : error LNK2001: unresolved external symbol
  pg_popcount32 [C:\projects\postgresql\pageinspect.vcxproj]
    .\Release\pageinspect\pageinspect.dll : fatal error LNK1120: 1
    unresolved externals [C:\projects\postgresql\pageinspect.vcxproj]

I think that it would be more simple to just use pg_popcount().
That's what other contrib modules do (for example ltree or intarray).
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20190905014131.GD14853@paquier.xyz/2-signature.asc)
  download

view thread (82+ messages)  latest in thread

Message-ID: <20190905014131.GD14853@paquier.xyz>
Permalink:  ../20190905014131.GD14853@paquier.xyz/
Also on:    postgresql.org/message-id/20190905014131.GD14853@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, alvherre@2ndquadrant.com, sawada.mshk@gmail.com, craig@2ndquadrant.com, ashu.coek88@gmail.com, rjuju123@gmail.com, pg@bowt.ie, ams@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, pavan.deolasee@2ndquadrant.com
  Subject: Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
  In-Reply-To: <20190905014131.GD14853@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox