From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Nikolay Shaplov <dhyan@nataraj.su>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Dent John <denty@qqdd.eu>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: [PATCH] src/test/modules/dummy_index -- way to test reloptions from inside of access method
Date: Tue, 24 Sep 2019 09:25:54 -0300
Message-ID: <20190924122554.GA23698@alvherre.pgsql> (raw)
In-Reply-To: <20190924023952.GG2012@paquier.xyz>
On 2019-Sep-24, Michael Paquier wrote:
> I looked at that over the last couple of days, and done as attached.
> Well, the actual module is in 0003. I have added more comments to
> document the basic AM calls so as it can easier be used as a template
> for some other work, and tweaked a couple of things. 0001 and 0002
> are just the patches from the other thread to address the issues with
> the lock mode of custom reloptions.
0003 looks useful, thanks for completing it. I think it would be a good
idea to test invalid values for each type of reloption too (passing
floating point to integers, strings to floating point, and so on).
If you can get this pushed, I'll push the enum reloptions on top.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, michael@paquier.xyz, dhyan@nataraj.su, thomas.munro@gmail.com, denty@qqdd.eu, pgsql-hackers@lists.postgresql.org, tgl@sss.pgh.pa.us, robertmhaas@gmail.com
Subject: Re: [PATCH] src/test/modules/dummy_index -- way to test reloptions from inside of access method
In-Reply-To: <20190924122554.GA23698@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox