From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Nikolay Shaplov <dhyan@nataraj.su>
Cc: pgsql-hackers@lists.postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Cc: Dent John <denty@qqdd.eu>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: [PATCH] src/test/modules/dummy_index -- way to test reloptions from inside of access method
Date: Wed, 25 Sep 2019 12:13:55 +0900
Message-ID: <20190925031355.GD1815@paquier.xyz> (raw)
In-Reply-To: <20190924153830.GA26314@alvherre.pgsql>
References: <9629467.uHNm3GW8oi@x200m>
<20190924153830.GA26314@alvherre.pgsql>
On Tue, Sep 24, 2019 at 12:38:30PM -0300, Alvaro Herrera wrote:
> On 2019-Sep-24, Nikolay Shaplov wrote:
>> В письме от вторник, 24 сентября 2019 г. 9:25:54 MSK пользователь Alvaro
>> Herrera написал:
>>> 0003 looks useful, thanks for completing it. I think it would be a good
>>> idea to test invalid values for each type of reloption too (passing
>>> floating point to integers, strings to floating point, and so on).
>>
>> We already do it in reloption regression tests.
>>
>> My idea was to test here only the things that can't be tested in regression
>> tests, on in real indexes like bloom.
>
> I suppose that makes sense. But of course when I push enum reloptions
> I will have to add such a test, since bloom does not have one.
Good point. We rely now on the GUC parsing for reloptions, so having
cross-checks about what patterns are allowed or not is a good idea for
all reloption types. I have added all that, and committed the
module. The amount of noise generated by the string validator routine
was a bit annoying, so I have silenced them where they don't really
matter (basically everything except the initial creation).
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, alvherre@2ndquadrant.com, dhyan@nataraj.su, thomas.munro@gmail.com, denty@qqdd.eu, tgl@sss.pgh.pa.us, robertmhaas@gmail.com
Subject: Re: [PATCH] src/test/modules/dummy_index -- way to test reloptions from inside of access method
In-Reply-To: <20190925031355.GD1815@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox