From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Nikolay Shaplov <dhyan@nataraj.su>
Cc: pgsql-hackers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Dent John <denty@qqdd.eu>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: [PATCH] src/test/modules/dummy_index -- way to test reloptions from inside of access method
Date: Tue, 24 Sep 2019 12:38:30 -0300
Message-ID: <20190924153830.GA26314@alvherre.pgsql> (raw)
In-Reply-To: <9629467.uHNm3GW8oi@x200m>
On 2019-Sep-24, Nikolay Shaplov wrote:
> В письме от вторник, 24 сентября 2019 г. 9:25:54 MSK пользователь Alvaro
> Herrera написал:
>
> > 0003 looks useful, thanks for completing it. I think it would be a good
> > idea to test invalid values for each type of reloption too (passing
> > floating point to integers, strings to floating point, and so on).
>
> We already do it in reloption regression tests.
>
> My idea was to test here only the things that can't be tested in regression
> tests, on in real indexes like bloom.
I suppose that makes sense. But of course when I push enum reloptions
I will have to add such a test, since bloom does not have one.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, dhyan@nataraj.su, michael@paquier.xyz, thomas.munro@gmail.com, denty@qqdd.eu, tgl@sss.pgh.pa.us, robertmhaas@gmail.com
Subject: Re: [PATCH] src/test/modules/dummy_index -- way to test reloptions from inside of access method
In-Reply-To: <20190924153830.GA26314@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox