From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Race condition in logical walsender causes long postgresql shutdown delay
Date: Thu, 26 Sep 2019 22:22:13 -0300
Message-ID: <20190927012213.GA10253@alvherre.pgsql> (raw)
In-Reply-To: <CAMkU=1xd2w6OmgHb_fCQW3-gHOswAEThqgkbZ=WLU_qbcok4Lg@mail.gmail.com>
On 2019-Sep-26, Jeff Janes wrote:
> On Wed, Sep 11, 2019 at 3:52 PM Alvaro Herrera <alvherre@2ndquadrant.com>
> wrote:
>
> > Reading over this code, I noticed that the detection of the catch-up
> > state ends up being duplicate code, so I would rework that function as
> > in the attached patch.
> >
> > The naming of those flags (got_SIGUSR2, got_STOPPING) is terrible, but
> > I'm not going to change that in a backpatchable bug fix.
>
> Hi Alvaro, does this count as a review?
Well, I'm already a second pair of eyes for Craig's code, so I think it
does :-) I would have liked confirmation from Craig that my change
looks okay to him too, but maybe we'll have to go without that.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, jeff.janes@gmail.com, craig@2ndquadrant.com
Subject: Re: [PATCH] Race condition in logical walsender causes long postgresql shutdown delay
In-Reply-To: <20190927012213.GA10253@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox