From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: pg_waldump erroneously outputs newline for FPWs, and another minor bug
Date: Mon, 4 Nov 2019 12:42:35 +0100
Message-ID: <20191104124235.02df2198@firost> (raw)
In-Reply-To: <20191030002621.GB1590@paquier.xyz>
References: <20191029233341.4gnyau7e5v2lh5sc@alap3.anarazel.de>
<CAH2-Wzn7Aw60HFvc=VrXpzqJAphPtuN2qLMj03FyyykMcBPMeA@mail.gmail.com>
<20191030002621.GB1590@paquier.xyz>
On Wed, 30 Oct 2019 09:26:21 +0900
Michael Paquier <michael@paquier.xyz> wrote:
> On Tue, Oct 29, 2019 at 04:42:07PM -0700, Peter Geoghegan wrote:
> > The same commit from Heikki omitted one field from that record, for no
> > good reason. I backpatched a bugfix to the output format for nbtree
> > page splits a few weeks ago, fixing that problem. I agree that we
> > should also backpatch this bugfix.
>
> The output format of pg_waldump may matter for some tools, like
> Jehan-Guillaume's PAF [1], but I am ready to bet that any tools like
> that just skip any noise newlines, so +1 for a backpatch.
>
> I am adding Jehan-Guillaume in CC just in case.
Thank you Michael!
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jgdr@dalibo.com, michael@paquier.xyz, pg@bowt.ie, andres@anarazel.de, hlinnaka@iki.fi
Subject: Re: pg_waldump erroneously outputs newline for FPWs, and another minor bug
In-Reply-To: <20191104124235.02df2198@firost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox