agora inbox for pgsql-hackers@postgresql.org  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: hlinnaka <hlinnaka@iki.fi>
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: [HACKERS] WAL logging problem in 9.4.3?
Date: Tue, 5 Nov 2019 14:53:35 -0800
Message-ID: <20191105225335.GA395764@rfd.leadboat.com> (raw)
In-Reply-To: <CA+TgmoYzTPpxvPUUs_ALW1YYNxV6mCrj6zwqnaN6FqdNc1JUzw@mail.gmail.com>
References: <20190828.154210.204505676.horikyota.ntt@gmail.com>
	<20191025.131251.322449872063947371.horikyota.ntt@gmail.com>
	<CAKPRHzJSgMuNeCtKgSxBJd2zOgK3BKL13Pkn_6_Sr9qXCRU=fQ@mail.gmail.com>
	<CA+TgmoYzTPpxvPUUs_ALW1YYNxV6mCrj6zwqnaN6FqdNc1JUzw@mail.gmail.com>

On Tue, Nov 05, 2019 at 04:16:14PM -0500, Robert Haas wrote:
> On Fri, Oct 25, 2019 at 9:21 AM Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
> > This is the fixed verison v22.
> 
> I'd like to offer a few thoughts on this thread and on these patches,
> which is now more than 4 years old and more than 150 messages in
> length.
...

Your understanding matches mine.  Thanks for studying this.  I had been
feeling nervous about being the sole reviewer of the latest design.

> Comments on comments, and other nitpicking:

I started pre-commit editing on 2019-10-28, and comment+README updates have
been the largest part of that.  I'll check my edits against the things you
list here, and I'll share on-list before committing.  I've now marked the CF
entry Ready for Committer.





view thread (244+ messages)  latest in thread

Message-ID: <20191105225335.GA395764@rfd.leadboat.com>
Permalink:  ../20191105225335.GA395764@rfd.leadboat.com/
Also on:    postgresql.org/message-id/20191105225335.GA395764@rfd.leadboat.com

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: noah@leadboat.com, robertmhaas@gmail.com, horikyota.ntt@gmail.com, 9erthalion6@gmail.com, andrew.dunstan@2ndquadrant.com, hlinnaka@iki.fi, michael@paquier.xyz
  Subject: Re: [HACKERS] WAL logging problem in 9.4.3?
  In-Reply-To: <20191105225335.GA395764@rfd.leadboat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox