From: Michael Paquier <michael@paquier.xyz>
To: Mark Dilger <hornschnorter@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Safeguards against incorrect fd flags for fsync()
Date: Mon, 25 Nov 2019 16:18:33 +0900
Message-ID: <20191125071833.GD99720@paquier.xyz> (raw)
In-Reply-To: <724f2e0a-9fd5-6e8a-5188-0fad8eb91bf7@gmail.com>
References: <20191009062640.GB21379@paquier.xyz>
<82db297a-74f7-ca23-545b-3c531d692e4d@gmail.com>
<20191125022858.GE37821@paquier.xyz>
<107de5d3-6972-7566-04d1-4776b677b462@gmail.com>
<724f2e0a-9fd5-6e8a-5188-0fad8eb91bf7@gmail.com>
On Sun, Nov 24, 2019 at 08:18:38PM -0800, Mark Dilger wrote:
> Ok, it passes all regression tests, and I played around with
> intentionally breaking the code to open file descriptors in
> the wrong mode. The assertion appears to work as intended.
>
> I'd say this is ready for commit.
Thanks for the review. I'll look at that pretty soon.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20191125071833.GD99720@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, hornschnorter@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Safeguards against incorrect fd flags for fsync()
In-Reply-To: <20191125071833.GD99720@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox