From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Alexey Bashtanov <bashtanov@imap.cc>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: log bind parameter values on error
Date: Mon, 25 Nov 2019 17:05:12 +0900
Message-ID: <20191125080512.GL99720@paquier.xyz> (raw)
In-Reply-To: <20191107234104.5vjj2nh3jdx3uvqo@alap3.anarazel.de>
References: <20190920174627.qmaditduxlrrzb5l@alap3.anarazel.de>
<20190920195657.GA20546@alvherre.pgsql>
<20190920203905.xkv5udsd5dxfs6tr@alap3.anarazel.de>
<4e374af0-5a2b-73fa-3dfe-d180fcd2ee3e@imap.cc>
<20191107234104.5vjj2nh3jdx3uvqo@alap3.anarazel.de>
On Thu, Nov 07, 2019 at 03:41:04PM -0800, Andres Freund wrote:
> The way you do it you need to do it in numerous places, and I'm pretty
> sure you're missing some already. E.g. this will not work to log
> parameters for parametrized statements generated on the server side,
> e.g. for foreign key queries. I don't think that's the right direction
> to go. You can maybe argue that we don't need support for logging server
> side generated parameters in the initial version, but the approach
> should be compatible with adding that support.
This patch had a review from two committers, with no updates from the
author, so marked as returned with feedback.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20191125080512.GL99720@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, andres@anarazel.de, bashtanov@imap.cc, alvherre@2ndquadrant.com, peter.eisentraut@2ndquadrant.com
Subject: Re: log bind parameter values on error
In-Reply-To: <20191125080512.GL99720@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox