From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Gasper Zejn <zejn@owca.info>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pglz performance
Date: Wed, 27 Nov 2019 15:41:59 -0300
Message-ID: <20191127184159.GA29849@alvherre.pgsql> (raw)
In-Reply-To: <8664A3B8-C049-45F5-9981-0E11BB619EE7@yandex-team.ru>
On 2019-Nov-27, Andrey Borodin wrote:
>
>
> > 27 нояб. 2019 г., в 20:28, Tomas Vondra <tomas.vondra@2ndquadrant.com> написал(а):
> >
> >>>
> >>> 6) I'm pretty sure the comment in the 'while (off < len)' branch will be
> >>> badly mangled by pgindent.
> >>
> >> I think I can just write it without line limit and then run pgindent.
> >> Will try to do it this evening. Also, I will try to write more about
> >> memmove.
> Well, yes, I could not make pgindent format some parts of that
> comment, gave up and left only simple text.
Please don't. The way to avoid pgindent from messing with the comment
is to surround it with dashes, /*--------- and end it with *------- */
Just make sure that you use well-aligned and lines shorter than 80, for
cleanliness; but whatever you do, if you use the dashes then pgindent
won't touch it.
(I think the closing dash line is not necessary, but it looks better for
things to be symmetrical.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, x4mmm@yandex-team.ru, tomas.vondra@2ndquadrant.com, michael@paquier.xyz, peter.eisentraut@2ndquadrant.com, zejn@owca.info, pgsql-hackers@lists.postgresql.org
Subject: Re: pglz performance
In-Reply-To: <20191127184159.GA29849@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox