From: Bruce Momjian <bruce@momjian.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: format of pg_upgrade loadable_libraries warning
Date: Wed, 27 Nov 2019 20:26:17 -0500
Message-ID: <20191128012617.GC27937@momjian.us> (raw)
In-Reply-To: <1053822A-7072-46F3-8569-53EEC21A8966@yesql.se>
References: <20191007174757.GE4732@momjian.us>
<20191114190652.GA23586@alvherre.pgsql>
<20191114221641.GD6160@momjian.us>
<1053822A-7072-46F3-8569-53EEC21A8966@yesql.se>
On Fri, Nov 15, 2019 at 12:32:55AM +0100, Daniel Gustafsson wrote:
> > On 14 Nov 2019, at 23:16, Bruce Momjian <bruce@momjian.us> wrote:
> >
> > On Thu, Nov 14, 2019 at 04:06:52PM -0300, Alvaro Herrera wrote:
> >> BTW, how is one supposed to "manually upgrade databases that use
> >> contrib/isb"? This part is not very clear.
> >
> > I thought you would dump out databases that use isn, drop those
> > databases, use pg_upgrade for the remaining databases, then load the
> > dumped database. Attached is a patch that improves the wording.
>
> I agree with this patch, that's much a more informative message.
>
> There is one tiny typo in the patch: s/laster/later/
>
> + "cluster, drop them, restart the upgrade, and restore them laster. A\n"
I have applied the patch, with improved wording. I only applied this to
PG 13 since I was worried old tools might be checking for the old error
text. Should this be backpatched more?
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, daniel@yesql.se, alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, pryzby@telsasoft.com, pgsql-hackers@lists.postgresql.org
Subject: Re: format of pg_upgrade loadable_libraries warning
In-Reply-To: <20191128012617.GC27937@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox