pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: andres@anarazel.de, Taylor Vesely <tvesely@pivotal.io>
Cc: Adam Lee <ali@pivotal.io>
Cc: Melanie Plageman <mplageman@pivotal.io>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Memory-Bounded Hash Aggregation
Date: Thu, 5 Dec 2019 23:04:57 +0100
Message-ID: <20191205220457.v3hg2vgkhpee5tfz@development> (raw)
In-Reply-To: <9723131d247b919f94699152647fa87ee0bc02c2.camel@j-davis.com>
References: <e13b52d4d8f9c10f7b58f39270213b868c99b685.camel@j-davis.com>
	<20190711155520.zqipi23o3yybx7ym@development>
	<9be86fc1adc315f69b8af4b379087ab451008d8a.camel@j-davis.com>
	<20190802064405.GA94036@mars.local>
	<617fea8258ba3df7bc8b21cd7f3afc219f2383d9.camel@j-davis.com>
	<20190802152123.ichmacgx3y3x7dc3@development>
	<CAFaX_4Ls5UGQ2UDYkWhn2xFq=V6BKpUbKSQnWmy27VWhQ2=enA@mail.gmail.com>
	<e52707d4665e32867fb6dd181825ef15f853b8bf.camel@j-davis.com>
	<20191128174644.snpuqldt5rndjru7@development>
	<9723131d247b919f94699152647fa87ee0bc02c2.camel@j-davis.com>

On Thu, Dec 05, 2019 at 12:55:51PM -0800, Jeff Davis wrote:
>On Thu, 2019-11-28 at 18:46 +0100, Tomas Vondra wrote:
>> And it's not clear to me why we should remove part of the comment
>> before
>> TupleHashTableHash.
>
>It looks like 5dfc1981 changed the signature of TupleHashTableHash
>without updating the comment, so it doesn't really make sense any more.
>I just updated the comment as a part of my patch, but it's not related.
>
>Andres, comments? Maybe we can just commit a fix for that comment and
>take it out of my patch.
>

+1 to push that as an independent fix


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services 





view thread (81+ messages)  latest in thread

Message-ID: <20191205220457.v3hg2vgkhpee5tfz@development>
Permalink:  ../20191205220457.v3hg2vgkhpee5tfz@development/
Also on:    postgresql.org/message-id/20191205220457.v3hg2vgkhpee5tfz@development

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, pgsql@j-davis.com, tvesely@pivotal.io, ali@pivotal.io, mplageman@pivotal.io
  Subject: Re: Memory-Bounded Hash Aggregation
  In-Reply-To: <20191205220457.v3hg2vgkhpee5tfz@development>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox