From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Arthur Zakirov <zaartur@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Allow to_date() and to_timestamp() to accept localized names
Date: Fri, 24 Jan 2020 13:18:14 -0300
Message-ID: <20200124161814.GA8989@alvherre.pgsql> (raw)
In-Reply-To: <b7f37b12-3c59-e5d7-0e59-535a117d259b@2ndquadrant.com>
On 2020-Jan-24, Peter Eisentraut wrote:
> When you interact with glibc locale functions, you essentially have to
> assume that everything is in NFC. When using ICU locale functions (which we
> don't here, but just for the sake of argument), then I would expect that ICU
> does appropriate normalization itself when I call
> icu_what_month_is_this(string) returns int. So I think it is appropriate to
> not deal with normalization in this patch.
But that's a different POV. The input to this function could come from
arbitrary user input from any application whatsoever. So the only
reason we can get away with that is because the example regression case
Juan José added (which uses non-normals) does not conform to the
standard.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, juanjo.santamaria@gmail.com, tgl@sss.pgh.pa.us, zaartur@gmail.com, tomas.vondra@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Allow to_date() and to_timestamp() to accept localized names
In-Reply-To: <20200124161814.GA8989@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox