From: Noah Misch <noah@leadboat.com>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: SimpleLruTruncate() mutual exclusion
Date: Fri, 31 Jan 2020 00:42:13 -0800
Message-ID: <20200131084213.GC3203372@rfd.leadboat.com> (raw)
In-Reply-To: <20200130153433.6gvgm723lzpgiogh@localhost>
References: <20190218073103.GA1434723@rfd.leadboat.com>
<20190628170628.GA1238361@rfd.leadboat.com>
<29566.1564419497@sss.pgh.pa.us>
<20190801065117.GA2355684@rfd.leadboat.com>
<20191117115652.doqc77yu7kbrqwmk@localhost>
<20191118061426.GA1173376@rfd.leadboat.com>
<20200130153433.6gvgm723lzpgiogh@localhost>
On Thu, Jan 30, 2020 at 04:34:33PM +0100, Dmitry Dolgov wrote:
> > On Sun, Nov 17, 2019 at 10:14:26PM -0800, Noah Misch wrote:
> > > I'm probably missing something, so just wanted to clarify. Do I
> > > understand correctly, that thread [1] and this one are independent, and
> > > it is assumed in the scenario above that we're at the end of XID space,
> > > but not necessarily having rounding issues? I'm a bit confused, since
> > > the reproduce script does something about cutoffPage, and I'm not sure
> > > if it's important or not.
> >
> > I think the repro recipe contained an early fix for the other thread's bug.
> > While they're independent in principle, I likely never reproduced this bug
> > without having a fix in place for the other thread's bug. The bug in the
> > other thread was easier to hit.
>
> Just to clarify, since the CF item for this patch was withdrawn
> recently. Does it mean that eventually the thread [1] covers this one
> too?
>
> [1]: https://www.postgresql.org/message-id/flat/20190202083822.GC32531%40gust.leadboat.com
I withdrew $SUBJECT because, if someone reviews one of my patches, I want it
to be the one you cite in [1]. I plan not to commit [1] without a Ready for
Committer, and I plan not to commit $SUBJECT before committing [1]. I would
be willing to commit $SUBJECT without getting a review, however.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, 9erthalion6@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: SimpleLruTruncate() mutual exclusion
In-Reply-To: <20200131084213.GC3203372@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox