From: Noah Misch <noah@leadboat.com>
To: Dmitry Dolgov <9erthalion6@gmail.com>
To: pgsql-hackers@postgresql.org
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: SimpleLruTruncate() mutual exclusion
Date: Sat, 1 Aug 2020 23:11:42 -0700
Message-ID: <20200802061142.GA27429@rfd.leadboat.com> (raw)
In-Reply-To: <20200131084213.GC3203372@rfd.leadboat.com>
References: <20190218073103.GA1434723@rfd.leadboat.com>
<20190628170628.GA1238361@rfd.leadboat.com>
<29566.1564419497@sss.pgh.pa.us>
<20190801065117.GA2355684@rfd.leadboat.com>
<20191117115652.doqc77yu7kbrqwmk@localhost>
<20191118061426.GA1173376@rfd.leadboat.com>
<20200130153433.6gvgm723lzpgiogh@localhost>
<20200131084213.GC3203372@rfd.leadboat.com>
On Fri, Jan 31, 2020 at 12:42:13AM -0800, Noah Misch wrote:
> On Thu, Jan 30, 2020 at 04:34:33PM +0100, Dmitry Dolgov wrote:
> > Just to clarify, since the CF item for this patch was withdrawn
> > recently. Does it mean that eventually the thread [1] covers this one
> > too?
> >
> > [1]: https://www.postgresql.org/message-id/flat/20190202083822.GC32531%40gust.leadboat.com
>
> I withdrew $SUBJECT because, if someone reviews one of my patches, I want it
> to be the one you cite in [1]. I plan not to commit [1] without a Ready for
> Committer, and I plan not to commit $SUBJECT before committing [1]. I would
> be willing to commit $SUBJECT without getting a review, however.
After further reflection, I plan to push $SUBJECT shortly after 2020-08-13,
not waiting for [1] to change status. Reasons:
- While I put significant weight on the fact that I couldn't reproduce
$SUBJECT problems without first fixing [1], I'm no longer confident of that
representing real-world experiences. Reproducing [1] absolutely requires a
close approach to a wrap limit, but $SUBJECT problems might not.
- Adding locks won't change correct functional behavior to incorrect
functional behavior.
- By pushing at that particular time, the fix ordinarily will appear in v13.0
before appearing in a back branch release. If problematic contention arises
quickly in the field, that's a more-comfortable way to discover it.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, 9erthalion6@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: SimpleLruTruncate() mutual exclusion
In-Reply-To: <20200802061142.GA27429@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox