From: Justin Pryzby <pryzby@telsasoft.com>
To: pgsql-hackers@postgresql.org
Subject: typos in comments and user docs
Date: Wed, 5 Feb 2020 20:14:32 -0600
Message-ID: <20200206021432.GA24549@telsasoft.com> (raw)
I sent earlier version of this a few times last year along with bunch of other
doc patches but it was never picked up. So maybe I'll try send one at a time
in more digestible chunks.
https://www.postgresql.org/message-id/flat/20190427025647.GD3925%40telsasoft.com#e1731c33455145eadc1...inline patch 1: doc/src/sgml/bloom.sgml, doc/src/sgml/config.sgml, doc/src/sgml/ref/alter_table.sgml and 5 more (+9/-9 lines) download 0001-spelling-and-typos.patchFrom cb5842724330dfcfc914f2e3effdbfe4843be565 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj@telsasoft.com>
Date: Thu, 9 May 2019 21:13:55 -0500
Subject: [PATCH] spelling and typos
---
doc/src/sgml/bloom.sgml | 2 +-
doc/src/sgml/config.sgml | 2 +-
doc/src/sgml/ref/alter_table.sgml | 2 +-
doc/src/sgml/sources.sgml | 4 ++--
src/backend/access/transam/README.parallel | 2 +-
src/backend/storage/buffer/bufmgr.c | 2 +-
src/backend/storage/sync/sync.c | 2 +-
src/include/access/tableam.h | 2 +-
8 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/doc/src/sgml/bloom.sgml b/doc/src/sgml/bloom.sgmlindex 6eeadde..c341b65 100644--- a/doc/src/sgml/bloom.sgml+++ b/doc/src/sgml/bloom.sgml@@ -65,7 +65,7 @@
<para>
Number of bits generated for each index column. Each parameter's name
refers to the number of the index column that it controls. The default
- is <literal>2</literal> bits and maximum is <literal>4095</literal>. Parameters for+ is <literal>2</literal> bits and the maximum is <literal>4095</literal>. Parameters for
index columns not actually used are ignored.
</para>
</listitem>
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgmlindex b2c89bd..102698b 100644--- a/doc/src/sgml/config.sgml+++ b/doc/src/sgml/config.sgml@@ -4318,7 +4318,7 @@ ANY <replaceable class="parameter">num_sync</replaceable> ( <replaceable class="
except crash recovery.
<varname>hot_standby_feedback</varname> will be delayed by use of this feature.
- Combinining these settings could lead to bloat on the master, so should+ Combining these settings could lead to bloat on the master, so should
be done only with care.
<warning>
diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgmlindex 5de3676..a22770c 100644--- a/doc/src/sgml/ref/alter_table.sgml+++ b/doc/src/sgml/ref/alter_table.sgml@@ -222,7 +222,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
<para>
<literal>SET NOT NULL</literal> may only be applied to a column
- providing none of the records in the table contain a+ provided none of the records in the table contain a
<literal>NULL</literal> value for the column. Ordinarily this is
checked during the <literal>ALTER TABLE</literal> by scanning the
entire table; however, if a valid <literal>CHECK</literal> constraint is
diff --git a/doc/src/sgml/sources.sgml b/doc/src/sgml/sources.sgmlindex 5831ec4..b5d28e7 100644--- a/doc/src/sgml/sources.sgml+++ b/doc/src/sgml/sources.sgml@@ -511,7 +511,7 @@ Hint: the addendum
<para>
There are functions in the backend that will double-quote their own output
- at need (for example, <function>format_type_be()</function>). Do not put+ as needed (for example, <function>format_type_be()</function>). Do not put
additional quotes around the output of such functions.
</para>
@@ -880,7 +880,7 @@ BETTER: unrecognized node type: 42
practices.
</para>
<para>
- Features from later revision of the C standard or compiler specific+ Features from later revisions of the C standard or compiler specific
features can be used, if a fallback is provided.
</para>
<para>
diff --git a/src/backend/access/transam/README.parallel b/src/backend/access/transam/README.parallelindex 85e5840..99c588d 100644--- a/src/backend/access/transam/README.parallel+++ b/src/backend/access/transam/README.parallel@@ -169,7 +169,7 @@ differently because of them. Right now, we don't even allow that.
At the end of a parallel operation, which can happen either because it
completed successfully or because it was interrupted by an error, parallel
workers associated with that operation exit. In the error case, transaction
-abort processing in the parallel leader kills of any remaining workers, and+abort processing in the parallel leader kills off any remaining workers, and
the parallel leader then waits for them to die. In the case of a successful
parallel operation, the parallel leader does not send any signals, but must
wait for workers to complete and exit of their own volition. In either
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.cindex aba3960..5880054 100644--- a/src/backend/storage/buffer/bufmgr.c+++ b/src/backend/storage/buffer/bufmgr.c@@ -4291,7 +4291,7 @@ ts_ckpt_progress_comparator(Datum a, Datum b, void *arg)
*
* *max_pending is a pointer instead of an immediate value, so the coalesce
* limits can easily changed by the GUC mechanism, and so calling code does
- * not have to check the current configuration. A value is 0 means that no+ * not have to check the current configuration. A value of 0 means that no
* writeback control will be performed.
*/
void
diff --git a/src/backend/storage/sync/sync.c b/src/backend/storage/sync/sync.cindex 9cb7c65..8282a47 100644--- a/src/backend/storage/sync/sync.c+++ b/src/backend/storage/sync/sync.c@@ -216,7 +216,7 @@ SyncPostCheckpoint(void)
/*
* As in ProcessSyncRequests, we don't want to stop absorbing fsync
- * requests for along time when there are many deletions to be done.+ * requests for a long time when there are many deletions to be done.
* We can safely call AbsorbSyncRequests() at this point in the loop
* (note it might try to delete list entries).
*/
diff --git a/src/include/access/tableam.h b/src/include/access/tableam.hindex 696451f..ba9f7b8 100644--- a/src/include/access/tableam.h+++ b/src/include/access/tableam.h@@ -1185,7 +1185,7 @@ table_tuple_complete_speculative(Relation rel, TupleTableSlot *slot,
* operation. That's often faster than calling table_insert() in a loop,
* because e.g. the AM can reduce WAL logging and page locking overhead.
*
- * Except for taking `nslots` tuples as input, as an array of TupleTableSlots+ * Except for taking `nslots` tuples as input, and an array of TupleTableSlots
* in `slots`, the parameters for table_multi_insert() are the same as for
* table_tuple_insert().
*
--
2.7.4
Patches and attachments:download all (2 files, .tar.gz)0001-spelling-and-typos.patch (text/x-diff, 6.1K) download
From cb5842724330dfcfc914f2e3effdbfe4843be565 Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj@telsasoft.com>
Date: Thu, 9 May 2019 21:13:55 -0500
Subject: [PATCH] spelling and typos
---
doc/src/sgml/bloom.sgml | 2 +-
doc/src/sgml/config.sgml | 2 +-
doc/src/sgml/ref/alter_table.sgml | 2 +-
doc/src/sgml/sources.sgml | 4 ++--
src/backend/access/transam/README.parallel | 2 +-
src/backend/storage/buffer/bufmgr.c | 2 +-
src/backend/storage/sync/sync.c | 2 +-
src/include/access/tableam.h | 2 +-
8 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/doc/src/sgml/bloom.sgml b/doc/src/sgml/bloom.sgmlindex 6eeadde..c341b65 100644--- a/doc/src/sgml/bloom.sgml+++ b/doc/src/sgml/bloom.sgml@@ -65,7 +65,7 @@
<para>
Number of bits generated for each index column. Each parameter's name
refers to the number of the index column that it controls. The default
- is <literal>2</literal> bits and maximum is <literal>4095</literal>. Parameters for+ is <literal>2</literal> bits and the maximum is <literal>4095</literal>. Parameters for
index columns not actually used are ignored.
</para>
</listitem>
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgmlindex b2c89bd..102698b 100644--- a/doc/src/sgml/config.sgml+++ b/doc/src/sgml/config.sgml@@ -4318,7 +4318,7 @@ ANY <replaceable class="parameter">num_sync</replaceable> ( <replaceable class="
except crash recovery.
<varname>hot_standby_feedback</varname> will be delayed by use of this feature.
- Combinining these settings could lead to bloat on the master, so should+ Combining these settings could lead to bloat on the master, so should
be done only with care.
<warning>
diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgmlindex 5de3676..a22770c 100644--- a/doc/src/sgml/ref/alter_table.sgml+++ b/doc/src/sgml/ref/alter_table.sgml@@ -222,7 +222,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
<para>
<literal>SET NOT NULL</literal> may only be applied to a column
- providing none of the records in the table contain a+ provided none of the records in the table contain a
<literal>NULL</literal> value for the column. Ordinarily this is
checked during the <literal>ALTER TABLE</literal> by scanning the
entire table; however, if a valid <literal>CHECK</literal> constraint is
diff --git a/doc/src/sgml/sources.sgml b/doc/src/sgml/sources.sgmlindex 5831ec4..b5d28e7 100644--- a/doc/src/sgml/sources.sgml+++ b/doc/src/sgml/sources.sgml@@ -511,7 +511,7 @@ Hint: the addendum
<para>
There are functions in the backend that will double-quote their own output
- at need (for example, <function>format_type_be()</function>). Do not put+ as needed (for example, <function>format_type_be()</function>). Do not put
additional quotes around the output of such functions.
</para>
@@ -880,7 +880,7 @@ BETTER: unrecognized node type: 42
practices.
</para>
<para>
- Features from later revision of the C standard or compiler specific+ Features from later revisions of the C standard or compiler specific
features can be used, if a fallback is provided.
</para>
<para>
diff --git a/src/backend/access/transam/README.parallel b/src/backend/access/transam/README.parallelindex 85e5840..99c588d 100644--- a/src/backend/access/transam/README.parallel+++ b/src/backend/access/transam/README.parallel@@ -169,7 +169,7 @@ differently because of them. Right now, we don't even allow that.
At the end of a parallel operation, which can happen either because it
completed successfully or because it was interrupted by an error, parallel
workers associated with that operation exit. In the error case, transaction
-abort processing in the parallel leader kills of any remaining workers, and+abort processing in the parallel leader kills off any remaining workers, and
the parallel leader then waits for them to die. In the case of a successful
parallel operation, the parallel leader does not send any signals, but must
wait for workers to complete and exit of their own volition. In either
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.cindex aba3960..5880054 100644--- a/src/backend/storage/buffer/bufmgr.c+++ b/src/backend/storage/buffer/bufmgr.c@@ -4291,7 +4291,7 @@ ts_ckpt_progress_comparator(Datum a, Datum b, void *arg)
*
* *max_pending is a pointer instead of an immediate value, so the coalesce
* limits can easily changed by the GUC mechanism, and so calling code does
- * not have to check the current configuration. A value is 0 means that no+ * not have to check the current configuration. A value of 0 means that no
* writeback control will be performed.
*/
void
diff --git a/src/backend/storage/sync/sync.c b/src/backend/storage/sync/sync.cindex 9cb7c65..8282a47 100644--- a/src/backend/storage/sync/sync.c+++ b/src/backend/storage/sync/sync.c@@ -216,7 +216,7 @@ SyncPostCheckpoint(void)
/*
* As in ProcessSyncRequests, we don't want to stop absorbing fsync
- * requests for along time when there are many deletions to be done.+ * requests for a long time when there are many deletions to be done.
* We can safely call AbsorbSyncRequests() at this point in the loop
* (note it might try to delete list entries).
*/
diff --git a/src/include/access/tableam.h b/src/include/access/tableam.hindex 696451f..ba9f7b8 100644--- a/src/include/access/tableam.h+++ b/src/include/access/tableam.h@@ -1185,7 +1185,7 @@ table_tuple_complete_speculative(Relation rel, TupleTableSlot *slot,
* operation. That's often faster than calling table_insert() in a loop,
* because e.g. the AM can reduce WAL logging and page locking overhead.
*
- * Except for taking `nslots` tuples as input, as an array of TupleTableSlots+ * Except for taking `nslots` tuples as input, and an array of TupleTableSlots
* in `slots`, the parameters for table_multi_insert() are the same as for
* table_tuple_insert().
*
--
2.7.4
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com
Subject: Re: typos in comments and user docs
In-Reply-To: <20200206021432.GA24549@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox