From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Antonin Houska <ah@cybertec.at>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Dead code in adminpack
Date: Fri, 14 Feb 2020 12:44:03 +0900
Message-ID: <20200214034403.GA1998@paquier.xyz> (raw)
In-Reply-To: <CAOBaU_Yp3euEyOV-nUOvtwjANYUypJN--RRoevDecRj6khWtNw@mail.gmail.com>
References: <32663.1581592539@antos>
<CAOBaU_Yp3euEyOV-nUOvtwjANYUypJN--RRoevDecRj6khWtNw@mail.gmail.com>
On Thu, Feb 13, 2020 at 12:41:46PM +0100, Julien Rouhaud wrote:
> On Thu, Feb 13, 2020 at 12:14 PM Antonin Houska <ah@cybertec.at> wrote:
>> I've noticed that convert_and_check_filename() is always passed false for the
>> "logAllowed" argument - someone probably forgot to remove the argument when it
>> was decided that log files are no longer accepted. If the argument was removed,
>> the function would become a bit simpler, see the patch.
>
> Indeed, and actually I don't see when this codepath was reachable.
>
> Patch LGTM.
Thanks, applied.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, rjuju123@gmail.com, ah@cybertec.at
Subject: Re: Dead code in adminpack
In-Reply-To: <20200214034403.GA1998@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox