pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Wait event that should be reported while waiting for WAL archiving to finish
Date: Tue, 18 Feb 2020 12:39:49 +0900
Message-ID: <20200218033949.GD4176@paquier.xyz> (raw)
In-Reply-To: <d9d85efa-f62e-400e-2edf-9e1b8c0df651@oss.nttdata.com>
References: <f0651f8c-9c96-9f29-0ff9-80414a15308a@oss.nttdata.com>
	<20200213032804.GB1520@paquier.xyz>
	<949931aa-4ed4-d867-a7b5-de9c02b2292b@oss.nttdata.com>
	<20200213073035.GI1520@paquier.xyz>
	<eb1287bd-64ee-07a5-057e-710d93e7f39e@oss.nttdata.com>
	<CA+Tgmoa3BVNJ+LVrytUrsK+MtxEogc_jurDgJ=rkMAEt06Hk6Q@mail.gmail.com>
	<61477660-dded-2550-b101-c76a2f864806@oss.nttdata.com>
	<20200217094857.GB115140@paquier.xyz>
	<d9d85efa-f62e-400e-2edf-9e1b8c0df651@oss.nttdata.com>

On Mon, Feb 17, 2020 at 10:21:23PM +0900, Fujii Masao wrote:
> On 2020/02/17 18:48, Michael Paquier wrote:
>> Actually, I have some questions:
>> 1) Should a new wait event be added in recoveryPausesHere()?  That
>> would be IMO useful.
> 
> Yes, it's useful, I think. But it's better to implement that
> as a separate patch.

No problem for me.

>> 2) Perhaps those two points should be replaced with WaitLatch(), where
>> we would use the new wait events introduced?
> 
> For what? Maybe it should, but I'm not sure it's worth the trouble.

I don't have more to offer than signal handling consistency for both
without relying on pg_usleep()'s behavior depending on the platform,
and power consumption.  For the recovery pause, the second argument
may not be worth carrying, but we never had this argument for the
archiving wait, did we?  For both, on top of it you don't need to
worry about concurrent issues with the wait events attached around.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (16+ messages)  latest in thread

Message-ID: <20200218033949.GD4176@paquier.xyz>
Permalink:  ../20200218033949.GD4176@paquier.xyz/
Also on:    postgresql.org/message-id/20200218033949.GD4176@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, masao.fujii@oss.nttdata.com, robertmhaas@gmail.com
  Subject: Re: Wait event that should be reported while waiting for WAL archiving to finish
  In-Reply-To: <20200218033949.GD4176@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox