From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Andreas Karlsson <andreas@proxel.se>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: reindex concurrently and two toast indexes
Date: Thu, 27 Feb 2020 16:32:11 +0900
Message-ID: <20200227073211.GA403330@paquier.xyz> (raw)
In-Reply-To: <20200222150657.GA54846@nol>
References: <20200216190835.GA21832@telsasoft.com>
<20200218052933.GH4176@paquier.xyz>
<CAOBaU_Z1-uD1nbnQwJXgSc2xYvPWe=Cn5vJwyAjOCd+tWfxt5w@mail.gmail.com>
<20200218061913.GJ4176@paquier.xyz>
<CAOBaU_bieK_PPD-NzBF1jR+QCNeJ75vZu_6hqCq_zbZHsDijgQ@mail.gmail.com>
<20200222070924.GA57285@nol>
<20200222150657.GA54846@nol>
On Sat, Feb 22, 2020 at 04:06:57PM +0100, Julien Rouhaud wrote:
> Sorry, I just realized that I forgot to commit the last changes before sending
> the patch, so here's the correct v2.
Thanks for the patch.
> + if (skipit)
> + {
> + ereport(NOTICE,
> + (errmsg("skipping invalid index \"%s.%s\"",
> + get_namespace_name(get_rel_namespace(indexOid)),
> + get_rel_name(indexOid))));
ReindexRelationConcurrently() issues a WARNING when bumping on an
invalid index, shouldn't the same log level be used?
Even with this patch, it is possible to reindex an invalid toast index
with REINDEX INDEX (with and without CONCURRENTLY), which is the
problem I mentioned upthread (Er, actually only for the non-concurrent
case as told about reindex_index). Shouldn't both cases be prevented
as well with an ERROR?
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20200227073211.GA403330@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, rjuju123@gmail.com, pryzby@telsasoft.com, sk@zsrv.org, peter.eisentraut@2ndquadrant.com, michael.paquier@gmail.com, andreas@proxel.se
Subject: Re: reindex concurrently and two toast indexes
In-Reply-To: <20200227073211.GA403330@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox