From: Adam Lee <ali@pivotal.io>
To: Jeff Davis <pgsql@j-davis.com>
Cc: pgsql-hackers@postgresql.org, Peter Geoghegan <pg@bowt.ie>
Cc: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Subject: Re: Add LogicalTapeSetExtend() to logtape.c
Date: Wed, 4 Mar 2020 11:57:19 +0800
Message-ID: <20200304035719.GB1022@earth.local> (raw)
In-Reply-To: <f68211cc9a413c23460f1058967993f8f0b52a2a.camel@j-davis.com>
References: <e54bfec11c59689890f277722aaaabd05f78e22c.camel@j-davis.com>
<20200228061641.GA883@earth.local>
<619e61919fd604c2caa629536ee87615b732e054.camel@j-davis.com>
<20200303014935.GA1022@earth.local>
<f68211cc9a413c23460f1058967993f8f0b52a2a.camel@j-davis.com>
On Tue, Mar 03, 2020 at 08:46:24AM -0800, Jeff Davis wrote:
> On Tue, 2020-03-03 at 09:49 +0800, Adam Lee wrote:
> > Master: 12729ms 12970ms 12999ms
> > With my patch(a pointer): 12965ms 13273ms 13116ms
> > With your patch(flexible array): 12906ms 12991ms 13043ms
>
> Hmm.. looks like you didn't reproduce the difference I saw. What
> compiler/version?
It was "Apple clang version 11.0.0 (clang-1100.0.33.17)".
Then I changed to "gcc-9 (Homebrew GCC 9.2.0_3) 9.2.0" this morning.
Master(e537aed61d): 13342.844 ms 13195.982 ms 13271.023 ms
With my patch(a pointer): 13020.029 ms 13008.158 ms 13063.658 ms
With your patch(flexible array): 12870.117 ms 12814.725 ms 13119.255 ms
--
Adam Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ali@pivotal.io, pgsql@j-davis.com, pg@bowt.ie, heikki.linnakangas@iki.fi
Subject: Re: Add LogicalTapeSetExtend() to logtape.c
In-Reply-To: <20200304035719.GB1022@earth.local>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox