From: Justin Pryzby <pryzby@telsasoft.com>
To: Mike Palmiotto <mike.palmiotto@crunchydata.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Auxiliary Processes and MyAuxProc
Date: Wed, 18 Mar 2020 09:17:20 -0500
Message-ID: <20200318141720.GH26184@telsasoft.com> (raw)
In-Reply-To: <CAMN686GixjieQhS9DtRvvAX9q73Px25yWuyWZRWeHh81ZE4XvA@mail.gmail.com>
References: <20200317215218.GC26184@telsasoft.com>
<20200318010433.GA17520@alvherre.pgsql>
<CAMN686GixjieQhS9DtRvvAX9q73Px25yWuyWZRWeHh81ZE4XvA@mail.gmail.com>
On Wed, Mar 18, 2020 at 09:22:58AM -0400, Mike Palmiotto wrote:
> On Tue, Mar 17, 2020 at 9:04 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> >
> > On 2020-Mar-17, Justin Pryzby wrote:
> >
> > > +static PgSubprocess process_types[] = {
> > > + {
> > > + .desc = "checker",
> > > + .entrypoint = CheckerModeMain
> > > + },
> > > + {
> > > + .desc = "bootstrap",
> > > + .entrypoint = BootstrapModeMain
> > > + },
> >
> > Maybe this stuff can be resolved using a technique like rmgrlist.h or
> > cmdtaglist.h. That way it's not in two separate files.
>
> Great suggestion, thanks! I'll try this out in the next version.
Also, I saw this was failing tests both before and after my rebase.
http://cfbot.cputube.org/https://ci.appveyor.com/project/postgresql-cfbot/postgresql/builds/31535161https://ci.appveyor.com/project/postgresql-cfbot/postgresql/builds/31386446
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, mike.palmiotto@crunchydata.com, alvherre@2ndquadrant.com, michael@paquier.xyz, andres@anarazel.de, yuli.khodorkovskiy@crunchydata.com, tgl@sss.pgh.pa.us
Subject: Re: Auxiliary Processes and MyAuxProc
In-Reply-To: <20200318141720.GH26184@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox