pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: pgsql-hackers@postgresql.org
Subject: Re: doc review for parallel vacuum
Date: Mon, 13 Apr 2020 16:24:40 -0500
Message-ID: <20200413212440.GB2228@telsasoft.com> (raw)
In-Reply-To: <CAA4eK1+_CcGmVqn8cRoSCdZeeoPdtoH0bXNOuuzqeub9ZeJ=vQ@mail.gmail.com>
References: <20200322021801.GB2563@telsasoft.com>
	<CAA4eK1Jwqq2=pukH212AvyWv6_oOJxM2YAypOEzR1KgeJj8_BQ@mail.gmail.com>
	<CAA4eK1+V5QovVH49=9RhsrshoNAA+TZBVGrv30xAqG0ncPUQaQ@mail.gmail.com>
	<20200407045551.GI2228@telsasoft.com>
	<CA+fd4k74vmiU=KdEjLJU4UQ99UvLn0mp-CKTkiF=bUdyk2PUNA@mail.gmail.com>
	<CAA4eK1JwUXkV4T2uAiLDYHT3efqkX2gE+Z5Z8g-DgCw377LN_g@mail.gmail.com>
	<20200410134644.GB2228@telsasoft.com>
	<CAA4eK1JoYKBcAJ5sgvbwGFwyu1Jr6faQqa8nn8tQuuewmpXs-Q@mail.gmail.com>
	<20200413083015.GQ2228@telsasoft.com>
	<CAA4eK1+_CcGmVqn8cRoSCdZeeoPdtoH0bXNOuuzqeub9ZeJ=vQ@mail.gmail.com>

On Mon, Apr 13, 2020 at 03:22:06PM +0530, Amit Kapila wrote:
> On Mon, Apr 13, 2020 at 2:00 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> >
> > |Copy the index
> > |bulk-deletion result returned from ambulkdelete and amvacuumcleanup to
> > |the DSM segment if it's the first time [???] because they allocate locally
> > |and it's possible that an index will be vacuumed by a different
> > |vacuum process the next time."
> >
> > Is it correct to say: "..if it's the first iteration" and "different process on
> > the next iteration" ?  Or "cycle" ?
> >
> 
> "cycle" sounds better.  I have changed the patch as per your latest
> comments.  Let me know what you think?

Looks good.  One more change:

[-Even if-]{+If+} this option is specified with the <option>ANALYZE</option> [-option-]{+option,+}

Remove "even" and add comma.

Thanks,
-- 
Justin





view thread (14+ messages)  latest in thread

Message-ID: <20200413212440.GB2228@telsasoft.com>
Permalink:  ../20200413212440.GB2228@telsasoft.com/
Also on:    postgresql.org/message-id/20200413212440.GB2228@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, amit.kapila16@gmail.com, masahiko.sawada@2ndquadrant.com, mahi6run@gmail.com, dilipbalaut@gmail.com, sk@zsrv.org
  Subject: Re: doc review for parallel vacuum
  In-Reply-To: <20200413212440.GB2228@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox