pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: DETACH PARTITION and FOR EACH ROW triggers on partitioned tables
Date: Tue, 21 Apr 2020 11:45:10 -0500
Message-ID: <20200421164510.GJ3890@telsasoft.com> (raw)
In-Reply-To: <20200421162038.GA18628@alvherre.pgsql>
References: <20200421154553.GA21155@alvherre.pgsql>
	<20200421162038.GA18628@alvherre.pgsql>

On Tue, Apr 21, 2020 at 12:20:38PM -0400, Alvaro Herrera wrote:
> diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
> index 7595e609b5..233905552c 100644
> --- a/doc/src/sgml/ref/alter_table.sgml
> +++ b/doc/src/sgml/ref/alter_table.sgml
> @@ -941,13 +943,14 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
>      <term><literal>DETACH PARTITION</literal> <replaceable class="parameter">partition_name</replaceable></term>
>      <listitem>
>       <para>
>        This form detaches specified partition of the target table.  The detached
>        partition continues to exist as a standalone table, but no longer has any
>        ties to the table from which it was detached.  Any indexes that were
> -      attached to the target table's indexes are detached.
> +      attached to the target table's indexes are detached.  Any triggers that
> +      were created to mirror those in the target table are removed.

Can you say "cloned" here instead of mirror ?
> +      attached to the target table's indexes are detached.  Any triggers that
> +      were created as clones of triggers in the target table are removed.

Also, I see in the surrounding context a missing word? 
This form detaches THE specified partition of the target table.

-- 
Justin





view thread (22+ messages)  latest in thread

Message-ID: <20200421164510.GJ3890@telsasoft.com>
Permalink:  ../20200421164510.GJ3890@telsasoft.com/
Also on:    postgresql.org/message-id/20200421164510.GJ3890@telsasoft.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, alvherre@2ndquadrant.com, amitlangote09@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: DETACH PARTITION and FOR EACH ROW triggers on partitioned tables
  In-Reply-To: <20200421164510.GJ3890@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox