From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Antonin Houska <ah@cybertec.at>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org
Subject: Re: 2pc leaks fds
Date: Tue, 21 Apr 2020 19:54:22 -0400
Message-ID: <20200421235422.GA28667@alvherre.pgsql> (raw)
In-Reply-To: <70539.1586332821@antos>
On 2020-Apr-08, Antonin Houska wrote:
> Specifically for 2PC, isn't it better to close some OS-level FD of an
> unrelated table scan and then succeed than to ERROR immediately? Anyway,
> 0dc8ead46 hasn't changed this.
I think for full generality of the interface, we pass a "close" callback
in addition to the "open" callback. But if we were to pass it only for
WALRead, then there would be no way to call it during XLogReaderFree.
I think the fix Andres applied is okay as far as it goes, but for the
long term we may want to change the interface even further -- maybe by
having these functions be part of the XLogReader state struct. I have
this code paged out of my head ATM, but maybe tomorrow I can give it a
little think.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, ah@cybertec.at, andres@anarazel.de, michael@paquier.xyz
Subject: Re: 2pc leaks fds
In-Reply-To: <20200421235422.GA28667@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox