From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Antonin Houska <ah@cybertec.at>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: andres@anarazel.de
Cc: michael@paquier.xyz
Cc: pgsql-hackers@postgresql.org
Subject: Re: 2pc leaks fds
Date: Mon, 11 May 2020 12:25:54 -0400
Message-ID: <20200511162554.GA10483@alvherre.pgsql> (raw)
In-Reply-To: <28250.1589186654@antos>
Hi Antonin, thanks for the review.
On 2020-May-11, Antonin Houska wrote:
> While looking at the changes, I've noticed a small comment issue in the
> XLogReaderRoutine structure definition:
>
> * "tli_p" is an input/output argument. XLogRead() uses it to pass the
>
> The XLogRead() function has been renamed to WALRead() in 0dc8ead4. (This
> incorrect comment was actually introduced by that commit.)
Ah. I'll fix this, thanks for pointing it out.
(It might be that the TLI situation can be improved with some callback,
too.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, ah@cybertec.at, horikyota.ntt@gmail.com, andres@anarazel.de, michael@paquier.xyz
Subject: Re: 2pc leaks fds
In-Reply-To: <20200511162554.GA10483@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox