agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org, Alexander Korotkov <a.korotkov@postgrespro.ru>
Subject: Re: doc review for v13
Date: Sun, 26 Apr 2020 11:13:24 -0500
Message-ID: <20200426161324.GS28974@telsasoft.com> (raw)
In-Reply-To: <20200414054754.GH1492@paquier.xyz>
References: <20200408165653.GF2228@telsasoft.com>
<20200410022746.GT1606@paquier.xyz>
<20200410030150.GZ2228@telsasoft.com>
<20200410062902.GX1606@paquier.xyz>
<20200412213545.GO2228@telsasoft.com>
<20200414054754.GH1492@paquier.xyz>
On Tue, Apr 14, 2020 at 02:47:54PM +0900, Michael Paquier wrote:
> On Sun, Apr 12, 2020 at 04:35:45PM -0500, Justin Pryzby wrote:
> > Added a few more.
> > And rebased on top of dbc60c5593f26dc777a3be032bff4fb4eab1ddd1
>
> Thanks for the patch set, I have applied the most obvious parts (more
> or less 1/3) to reduce the load. Here is a review of the rest.
Thanks - attached are the remaining undisputed portions..
> > +++ b/doc/src/sgml/ref/alter_table.sgml
> > @@ -889,7 +889,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
> > from the parent table will be created in the partition, if they don't
> > already exist.
> > If any of the <literal>CHECK</literal> constraints of the table being
> > - attached is marked <literal>NO INHERIT</literal>, the command will fail;
> > + attached are marked <literal>NO INHERIT</literal>, the command will fail;
> > such constraints must be recreated without the
> > <literal>NO INHERIT</literal> clause.
> > </para>
>
> It seems to me that both are actually correct here.
I think my text is correct. This would *also* be correct:
| If any <literal>CHECK</literal> constraint on the table being
| attached is marked <literal>NO INHERIT</literal>, the command will fail;
But not the hybrid: "If any OF THE .. is .."
--
Justin
Attachments:
[text/x-diff] v4-0001-doc-percent-encoding.patch (0B, ../20200426161324.GS28974@telsasoft.com/2-v4-0001-doc-percent-encoding.patch)
download
view thread (22+ messages) latest in thread
Message-ID: <20200426161324.GS28974@telsasoft.com>
Permalink: ../20200426161324.GS28974@telsasoft.com/
Also on: postgresql.org/message-id/20200426161324.GS28974@telsasoft.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, michael@paquier.xyz, a.korotkov@postgrespro.ru
Subject: Re: doc review for v13
In-Reply-To: <20200426161324.GS28974@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox