pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Kuntal Ghosh <kuntalghosh.2007@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Kirill Bychik <kirill.bychik@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: WAL usage calculation patch
Date: Mon, 27 Apr 2020 15:11:50 +0900
Message-ID: <20200427061150.GD11369@paquier.xyz> (raw)
In-Reply-To: <CAA4eK1KjohVM6Fgvg37cu9KnPDL2MgKWnMh3ZJho_Ef+-5w2hA@mail.gmail.com>
References: <20200418204105.GL26953@telsasoft.com>
	<CAOBaU_Z5dK=cMXTaEEgXNCY7GrsBnVfk4vwK2h7o+2Aowb33Qw@mail.gmail.com>
	<20200420.164656.881770765734654652.horikyota.ntt@gmail.com>
	<CAA4eK1JjkkmTcZFa1taS0uUpPM3KeYb_oJd0ak8QchsAs29eFg@mail.gmail.com>
	<20200422035501.GN3890@telsasoft.com>
	<CAA4eK1Kg4Tup076MtbzJkp9vTp=f9orkVaDgtLSnwC_GF1YRSg@mail.gmail.com>
	<CAOBaU_bUGhaXB0Q00FGtowjXgbPGOAcn6CxjY5zXSeT4ZuWkAA@mail.gmail.com>
	<05bdb944-e12b-232a-41c0-e78cc9e63d17@2ndquadrant.com>
	<CAA4eK1KYZTeVQ3AWVOBkby4pUq4wY07iKpq2b6_X+xXyY6_5gA@mail.gmail.com>
	<CAA4eK1KjohVM6Fgvg37cu9KnPDL2MgKWnMh3ZJho_Ef+-5w2hA@mail.gmail.com>

On Mon, Apr 27, 2020 at 08:35:51AM +0530, Amit Kapila wrote:
> On Thu, Apr 23, 2020 at 2:35 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>> On Thu, Apr 23, 2020 at 12:16 PM Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>>>  The internal symbol for the WAL record is
>>> XLOG_FPI and xlogdesc.c prints it as "FPI".
> 
> Julien, Peter, others do you have any opinion here?  I think it is
> better if we decide on one of FPW or FPI and make the changes at all
> places for this patch.

It seems to me that Peter is right here.  A full-page write is the
action to write a full-page image, so if you consider only a way to
define the static data of a full-page and/or a quantity associated to
it, we should talk about full-page images.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (130+ messages)  latest in thread

Message-ID: <20200427061150.GD11369@paquier.xyz>
Permalink:  ../20200427061150.GD11369@paquier.xyz/
Also on:    postgresql.org/message-id/20200427061150.GD11369@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, amit.kapila16@gmail.com, peter.eisentraut@2ndquadrant.com, rjuju123@gmail.com, pryzby@telsasoft.com, horikyota.ntt@gmail.com, dilipbalaut@gmail.com, kuntalghosh.2007@gmail.com, masao.fujii@oss.nttdata.com, kirill.bychik@gmail.com, thomas.munro@gmail.com
  Subject: Re: WAL usage calculation patch
  In-Reply-To: <20200427061150.GD11369@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox