From: Antonin Houska <ah@cybertec.at>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: andres@anarazel.de
Cc: michael@paquier.xyz
Cc: pgsql-hackers@postgresql.org
Subject: Re: 2pc leaks fds
Date: Mon, 11 May 2020 10:44:14 +0200
Message-ID: <28250.1589186654@antos> (raw)
In-Reply-To: <20200508210916.GA23288@alvherre.pgsql>
References: <20200508210916.GA23288@alvherre.pgsql>
Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> On 2020-May-08, Kyotaro Horiguchi wrote:
>
> > I agree to the direction of this patch. Thanks for the explanation.
> > The patch looks good to me except the two points below.
>
> Thanks! I pushed the patch.
I tried to follow the discussion but haven't had better idea. This looks
better than the previous version. Thanks!
While looking at the changes, I've noticed a small comment issue in the
XLogReaderRoutine structure definition:
* "tli_p" is an input/output argument. XLogRead() uses it to pass the
The XLogRead() function has been renamed to WALRead() in 0dc8ead4. (This
incorrect comment was actually introduced by that commit.)
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ah@cybertec.at, alvherre@2ndquadrant.com, horikyota.ntt@gmail.com, andres@anarazel.de, michael@paquier.xyz
Subject: Re: 2pc leaks fds
In-Reply-To: <28250.1589186654@antos>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox