pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Review for GetWALAvailability()
Date: Tue, 16 Jun 2020 22:40:56 -0400
Message-ID: <20200617024056.GA21726@alvherre.pgsql> (raw)
In-Reply-To: <f279ada0-d5e2-5284-d3fb-46b3943b6c79@oss.nttdata.com>

On 2020-Jun-17, Fujii Masao wrote:
> On 2020/06/17 3:50, Alvaro Herrera wrote:

> So InvalidateObsoleteReplicationSlots() can terminate normal backends.
> But do we want to do this? If we want, we should add the note about this
> case into the docs? Otherwise the users would be surprised at termination
> of backends by max_slot_wal_keep_size. I guess that it's basically rarely
> happen, though.

Well, if we could distinguish a walsender from a non-walsender process,
then maybe it would make sense to leave backends alive.  But do we want
that?  I admit I don't know what would be the reason to have a
non-walsender process with an active slot, so I don't have a good
opinion on what to do in this case.

> > > +		/*
> > > +		 * Signal to terminate the process using the replication slot.
> > > +		 *
> > > +		 * Try to signal every 100ms until it succeeds.
> > > +		 */
> > > +		if (!killed && kill(active_pid, SIGTERM) == 0)
> > > +			killed = true;
> > > +		ConditionVariableTimedSleep(&slot->active_cv, 100,
> > > +									WAIT_EVENT_REPLICATION_SLOT_DROP);
> > > +	} while (ReplicationSlotIsActive(slot, NULL));
> > 
> > Note that here you're signalling only once and then sleeping many times
> > in increments of 100ms -- you're not signalling every 100ms as the
> > comment claims -- unless the signal fails, but you don't really expect
> > that.  On the contrary, I'd claim that the logic is reversed: if the
> > signal fails, *then* you should stop signalling.
> 
> You mean; in this code path, signaling fails only when the target process
> disappears just before signaling. So if it fails, slot->active_pid is
> expected to become 0 even without signaling more. Right?

I guess kill() can also fail if the PID now belongs to a process owned
by a different user.  I think we've disregarded very quick reuse of
PIDs, so we needn't concern ourselves with it.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (38+ messages)  latest in thread

Message-ID: <20200617024056.GA21726@alvherre.pgsql>
Permalink:  ../20200617024056.GA21726@alvherre.pgsql/
Also on:    postgresql.org/message-id/20200617024056.GA21726@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@2ndquadrant.com, masao.fujii@oss.nttdata.com, horikyota.ntt@gmail.com
  Subject: Re: Review for GetWALAvailability()
  In-Reply-To: <20200617024056.GA21726@alvherre.pgsql>
  References: <f279ada0-d5e2-5284-d3fb-46b3943b6c79@oss.nttdata.com> <20200617024056.GA21726@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox