From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: tgl@sss.pgh.pa.us
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_regress cleans up tablespace twice.
Date: Thu, 18 Jun 2020 10:42:00 +0900
Message-ID: <20200618014200.GD118592@paquier.xyz> (raw)
In-Reply-To: <20200617.170231.2041463748911808790.horikyota.ntt@gmail.com>
References: <20200515025855.GE2462@paquier.xyz>
<20200515.172508.1423943947298901347.horikyota.ntt@gmail.com>
<20200617070804.GC2361@paquier.xyz>
<20200617.170231.2041463748911808790.horikyota.ntt@gmail.com>
On Wed, Jun 17, 2020 at 05:02:31PM +0900, Kyotaro Horiguchi wrote:
> It look good to me as the Windows part. I agree that vcregress.pl
> don't need to parse EXTRA_REGRESS_OPTS by allowing a bit more tight
> bond between the caller sites of pg_regress and pg_regress.
Thanks, applied this part to HEAD then after more testing.
> Chaining to TAP sounds nice as a goal.
I submitted a patch for that, but we had no clear agreements about how
to handle major upgrades, as this involves a somewhat large
refactoring of PostgresNode.pm so as you register a path to the
binaries used by a given node registered.
> As the next step we need to amend GNUmakefile not to cleanup
> tablespace for the four test items. Then somehow treat tablespaces at
> non-default place?
Ah, you mean to not reset testtablespace where that's not necessary in
the tests by reworking the rules? Yeah, perhaps we could do something
like that. Not sure yet how to shape that in term of code but if you
have a clear idea, please feel free to submit it. I think that this
may be better if discussed on a different thread though.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, horikyota.ntt@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_regress cleans up tablespace twice.
In-Reply-To: <20200618014200.GD118592@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox