From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Review for GetWALAvailability()
Date: Wed, 24 Jun 2020 23:57:18 -0400
Message-ID: <20200625035718.GA28721@alvherre.pgsql> (raw)
In-Reply-To: <17a69cfe-f1c1-a416-ee25-ae15427c69eb@oss.nttdata.com>
On 2020-Jun-25, Fujii Masao wrote:
> /*
> * Find the oldest extant segment file. We get 1 until checkpoint removes
> * the first WAL segment file since startup, which causes the status being
> * wrong under certain abnormal conditions but that doesn't actually harm.
> */
> oldestSeg = XLogGetLastRemovedSegno() + 1;
>
> I see the point of the above comment, but this can cause wal_status to be
> changed from "lost" to "unreserved" after the server restart. Isn't this
> really confusing? At least it seems better to document that behavior.
Hmm.
> Or if we *can ensure* that the slot with invalidated_at set always means
> "lost" slot, we can judge that wal_status is "lost" without using fragile
> XLogGetLastRemovedSegno(). Thought?
Hmm, this sounds compelling -- I think it just means we need to ensure
we reset invalidated_at to zero if the slot's restart_lsn is set to a
correct position afterwards. I don't think we have any operation that
does that, so it should be safe -- hopefully I didn't overlook anything?
Neither copy nor advance seem to work with a slot that has invalid
restart_lsn.
> Or XLogGetLastRemovedSegno() should be fixed so that it returns valid
> value even after the restart?
This seems more work to implement.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, masao.fujii@oss.nttdata.com, horikyota.ntt@gmail.com
Subject: Re: Review for GetWALAvailability()
In-Reply-To: <20200625035718.GA28721@alvherre.pgsql>
References: <17a69cfe-f1c1-a416-ee25-ae15427c69eb@oss.nttdata.com> <20200625035718.GA28721@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox