pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: PG 13 release notes, first draft
Date: Fri, 26 Jun 2020 18:24:23 -0400
Message-ID: <20200626222423.GC3337@momjian.us> (raw)
In-Reply-To: <20200626202326.GA5823@alvherre.pgsql>
References: <20200626202036.GA5474@alvherre.pgsql>
	<20200626202326.GA5823@alvherre.pgsql>

On Fri, Jun 26, 2020 at 04:23:26PM -0400, Alvaro Herrera wrote:
> Reading Luis Carril's other entry in the relnotes,
> 
>  Allow pg_dump --include-foreign-data to dump data from foreign servers (Luis Carril)
> 
> It seems to suggest that --include-foreign-data existed previously,
> which is not true. I would have worded it as "Add --include-foreign-data
> option to pg_dump to allow dumping data from foreign servers".

OK, pg_dump item about FOREIGN keyword removed from PG 13 release notes,
and the above item clarified.   Patch attached and applied to PG 13.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee

Attachments:

foreign.diff (text/x-diff, 1.3K) download
diff --git a/doc/src/sgml/release-13.sgml b/doc/src/sgml/release-13.sgml
new file mode 100644
index 401c557..45d8f0b
*** a/doc/src/sgml/release-13.sgml
--- b/doc/src/sgml/release-13.sgml
*************** Author: Peter Eisentraut <peter@eisentra
*** 1534,1555 ****
        </para>
       </listitem>
  
-      <listitem>
- <!--
- Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
- 2020-03-20 [4e6209134] pg_dump: Add FOREIGN to ALTER statements, if appropriate
- -->
- 
-       <para>
-        Add <literal>FOREIGN</literal> to <command>ALTER</command> statements,
-        if appropriate (Luis Carril)
-       </para>
- 
-       <para>
-        WHAT IS THIS ABOUT?
-       </para>
-      </listitem>
- 
      </itemizedlist>
  
     </sect3>
--- 1534,1539 ----
*************** Author: Alvaro Herrera <alvherre@alvh.no
*** 2414,2423 ****
  -->
  
        <para>
!        Allow <link
         linkend="app-pgdump"><application>pg_dump</application></link>
!        <option>--include-foreign-data</option> to dump data from foreign
!        servers (Luis Carril)
        </para>
       </listitem>
  
--- 2398,2407 ----
  -->
  
        <para>
!        Add <link
         linkend="app-pgdump"><application>pg_dump</application></link>
!        option <option>--include-foreign-data</option> to dump data from
!        foreign servers (Luis Carril)
        </para>
       </listitem>
  

view thread (194+ messages)  latest in thread

Message-ID: <20200626222423.GC3337@momjian.us>
Permalink:  ../20200626222423.GC3337@momjian.us/
Also on:    postgresql.org/message-id/20200626222423.GC3337@momjian.us

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: bruce@momjian.us, alvherre@2ndquadrant.com, masahiko.sawada@2ndquadrant.com
  Subject: Re: PG 13 release notes, first draft
  In-Reply-To: <20200626222423.GC3337@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox